[scheduler] Add a CHECK for renderer main thread load metrics.

[scheduler] Add a CHECK for renderer main thread load metrics.

Change DCHECK to CHECK in RendererScheduler's
Report{Foreground,Background}RendererThreadLoad. This should help pin
down strange anomalies from metrics.

This patch should be Canary-channel only, and expected to be extremely
rare (less than 1 failure/day on Canary). Please revert without asking
if something goes wrong.

BUG=693542
Review-Url: https://codereview.chromium.org/2720023003
Cr-Commit-Position: refs/heads/master@{#453783}
Committed: https://chromium.googlesource.com/chromium/src/+/2100af86f06ded92e913c67723bbff9af08df307

[altimin, 2017-02-28 15:55:50]

altimin@chromium.org changed reviewers:
+ skyostil@chromium.org

[altimin, 2017-02-28 15:55:51]

PTAL

[Sami, 2017-02-28 16:07:20]

lgtm.

https://codereview.chromium.org/2720023003/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
(right):

https://codereview.chromium.org/2720023003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc:58:
CHECK_LE(load_percentage, 100);
Add a TODO to revert.

[altimin, 2017-02-28 16:16:51]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 16:17:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 18:32:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 18:32:40]

Dry run: This issue passed the CQ dry run.

[altimin, 2017-03-01 00:49:09]

The CQ bit was checked by altimin@chromium.org

[altimin, 2017-03-01 00:49:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2720023003/#ps20001
(title: "git cl try")

[commit-bot: I haz the power, 2017-03-01 00:49:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 00:54:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488329349171150,
"parent_rev": "dc4b182689f70d46e9f80a226837c25a41b3b9a5", "commit_rev":
"2100af86f06ded92e913c67723bbff9af08df307"}

[commit-bot: I haz the power, 2017-03-01 00:55:30]

Description was changed from

==========
[scheduler] Add a CHECK for renderer main thread load metrics.

Change DCHECK to CHECK in RendererScheduler's
Report{Foreground,Background}RendererThreadLoad. This should help pin
down strange anomalies from metrics.

This patch should be Canary-channel only, and expected to be extremely
rare (less than 1 failure/day on Canary). Please revert without asking
if something goes wrong.

BUG=693542
==========

to

==========
[scheduler] Add a CHECK for renderer main thread load metrics.

Change DCHECK to CHECK in RendererScheduler's
Report{Foreground,Background}RendererThreadLoad. This should help pin
down strange anomalies from metrics.

This patch should be Canary-channel only, and expected to be extremely
rare (less than 1 failure/day on Canary). Please revert without asking
if something goes wrong.

BUG=693542

Review-Url: https://codereview.chromium.org/2720023003
Cr-Commit-Position: refs/heads/master@{#453783}
Committed:
https://chromium.googlesource.com/chromium/src/+/2100af86f06ded92e913c67723bb...
==========

[commit-bot: I haz the power, 2017-03-01 00:55:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2100af86f06ded92e913c67723bb...

[Sami, 2017-03-22 18:36:47]

Any results? Should we revert this now?

[altimin, 2017-03-23 13:55:14]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2769133003/ by altimin@chromium.org.

The reason for reverting is: Revert temporary CHECK back to DCHECK.

[altimin, 2017-03-23 13:57:04]

On 2017/03/22 18:36:47, Sami wrote:
> Any results? Should we revert this now?

I see a few crashes, but I'm not sure if they are useful. Regardless of that,
this patch needs to be reverted, thanks for reminding me.