Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2769083003: [ARM] Make Simd 128 bit load/store more like existing load/store. (Closed)

Created:
3 years, 9 months ago by bbudge
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM] Make Simd 128 bit load/store more like existing load/store. - Renames kArmSimd128Load, kArmSimd128Store to kArmVld1S128, kArmVst1S128 - Handles the unaligned load/store cases. LOG=N BUG=v8:6020 Review-Url: https://codereview.chromium.org/2769083003 Cr-Commit-Position: refs/heads/master@{#44117} Committed: https://chromium.googlesource.com/v8/v8/+/6839e7ac083fca721e9954ac545d7536615fd859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -28 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 3 chunks +11 lines, -13 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/arm/instruction-scheduler-arm.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 8 chunks +23 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
bbudge
3 years, 9 months ago (2017-03-24 00:01:53 UTC) #6
bbudge
+Benedikt for compiler
3 years, 9 months ago (2017-03-24 01:14:53 UTC) #8
Benedikt Meurer
lgtm
3 years, 9 months ago (2017-03-24 07:44:22 UTC) #9
martyn.capewell
lgtm
3 years, 9 months ago (2017-03-24 11:21:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769083003/1
3 years, 9 months ago (2017-03-24 14:46:30 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 17:40:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6839e7ac083fca721e9954ac545d7536615...

Powered by Google App Engine
This is Rietveld 408576698