Add GPU integration pixel tests for VP9 and MP4 video.

Add GPU integration pixel tests for VP9 and MP4 video.

Ensure that the compositor draws these correctly.

BUG=704389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2769063006
Cr-Commit-Position: refs/heads/master@{#460598}
Committed: https://chromium.googlesource.com/chromium/src/+/434832f73131bcf29f81a268b28211e64329d61d

[jbauman, 2017-03-24 23:15:10]

Description was changed from

==========
Add GPU integration pixel tests for VP9 and MP4 video.

Ensure that the compositor draws these correctly.

BUG=704389
==========

to

==========
Add GPU integration pixel tests for VP9 and MP4 video.

Ensure that the compositor draws these correctly.

BUG=704389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-03-24 23:15:16]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 23:16:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 23:58:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 23:58:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbauman, 2017-03-27 22:08:09]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 22:08:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 00:46:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 00:46:10]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-03-28 01:11:13]

jbauman@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-03-28 01:21:52]

Thanks for adding these important tests. A couple of questions.

https://codereview.chromium.org/2769063006/diff/20001/content/test/data/gpu/p...
File content/test/data/gpu/pixel_video_mp4.html (right):

https://codereview.chromium.org/2769063006/diff/20001/content/test/data/gpu/p...
content/test/data/gpu/pixel_video_mp4.html:30:
domAutomationController.send("SUCCESS");
It looks to me like this test might currently be flaky. Currently there's no
guarantee that the video actually loaded before the page starts counting down
and sending the notification to the harness to take the screen shot.

Should we wait for the "oncanplaythrough" or similar event before running
main()?

Does the video need to play before hardware-accelerated decoding for it will be
enabled? If not, then this looks OK, but if yes, then the test should initiate
playback. Maybe webgl-test-utils' startPlayingAndWaitForVideo helper function
would be useful:

https://cs.chromium.org/chromium/src/third_party/webgl/src/sdk/tests/js/webgl...

[jbauman, 2017-03-28 01:42:35]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 01:43:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2017-03-28 01:53:59]

On 2017/03/28 01:21:52, Ken Russell wrote:
> Thanks for adding these important tests. A couple of questions.
> 
>
https://codereview.chromium.org/2769063006/diff/20001/content/test/data/gpu/p...
> File content/test/data/gpu/pixel_video_mp4.html (right):
> 
>
https://codereview.chromium.org/2769063006/diff/20001/content/test/data/gpu/p...
> content/test/data/gpu/pixel_video_mp4.html:30:
> domAutomationController.send("SUCCESS");
> It looks to me like this test might currently be flaky. Currently there's no
> guarantee that the video actually loaded before the page starts counting down
> and sending the notification to the harness to take the screen shot.
> 
> Should we wait for the "oncanplaythrough" or similar event before running
> main()?

Yeah, changed to do that.
> 
> Does the video need to play before hardware-accelerated decoding for it will
be
> enabled? If not, then this looks OK, but if yes, then the test should initiate
> playback. Maybe webgl-test-utils' startPlayingAndWaitForVideo helper function
> would be useful:
> 
>
https://cs.chromium.org/chromium/src/third_party/webgl/src/sdk/tests/js/webgl...

We use hardware decoding for the first frame, so just displaying the video
paused in the page is enough to test it.

[commit-bot: I haz the power, 2017-03-28 02:44:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 02:44:33]

Dry run: Try jobs failed on following builders:
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)

[jbauman, 2017-03-28 03:24:18]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 03:24:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 04:25:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 04:25:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[DaleCurtis, 2017-03-28 17:09:32]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2017-03-28 17:09:33]

Can you use the test data from media/test/data instead? It already has vp9
clips; I'm surprised content/test/data doesn't though. Really that dir should
probably be nuked, I believe most tests have been switched to read from
media/test/data instead.

[jbauman, 2017-03-28 21:37:03]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 21:37:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2017-03-28 21:54:58]

Thanks for updating the test John, and thanks Dale for the suggestion to reuse
existing test data. lgtm

[commit-bot: I haz the power, 2017-03-28 22:18:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 22:18:03]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[DaleCurtis, 2017-03-29 22:55:29]

lgtm

[jbauman, 2017-03-29 23:14:42]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2017-03-29 23:15:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 00:35:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490829282421450,
"parent_rev": "df6186f7c0a8611fdd4425338cc6a1dceeaa2e7e", "commit_rev":
"434832f73131bcf29f81a268b28211e64329d61d"}

[commit-bot: I haz the power, 2017-03-30 00:37:00]

Description was changed from

==========
Add GPU integration pixel tests for VP9 and MP4 video.

Ensure that the compositor draws these correctly.

BUG=704389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add GPU integration pixel tests for VP9 and MP4 video.

Ensure that the compositor draws these correctly.

BUG=704389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2769063006
Cr-Commit-Position: refs/heads/master@{#460598}
Committed:
https://chromium.googlesource.com/chromium/src/+/434832f73131bcf29f81a268b282...
==========

[commit-bot: I haz the power, 2017-03-30 00:37:01]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/434832f73131bcf29f81a268b282...