content/test/data/gpu/pixel_video_mp4.html - Issue 2769063006: Add GPU integration pixel tests for VP9 and MP4 video.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/gpu/pixel_video_mp4.html

Issue 2769063006: Add GPU integration pixel tests for VP9 and MP4 video. (Closed)

Patch Set: better Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2

	3 <!-- READ BEFORE UPDATING:

	4 If this test is updated make sure to increment the "revision" value of the

	5 associated test in content/test/gpu/page_sets/pixel_tests.py. This will ensure

	6 that the baseline images are regenerated on the next run.

	7 -->

	8

	9 <html>

	10 <head>

	11 <title>MP4 Video test</title>

	12 <style type="text/css">

	13 .nomargin {

	14 margin: 0px auto;

	15 }

	16 </style>

	17 <script>

	18 var g_swapsBeforeAck = 15;

	19

	20 function main()

	21 {

	22 waitForFinish();

	23 }

	24

	25

	26 function waitForFinish()

	27 {

	28 if (g_swapsBeforeAck == 0) {

	29 domAutomationController.setAutomationId(1);

	30 domAutomationController.send("SUCCESS");
	Ken Russell (switch to Gerrit) 2017/03/28 01:21:52 It looks to me like this test might currently be f It looks to me like this test might currently be flaky. Currently there's no guarantee that the video actually loaded before the page starts counting down and sending the notification to the harness to take the screen shot. Should we wait for the "oncanplaythrough" or similar event before running main()? Does the video need to play before hardware-accelerated decoding for it will be enabled? If not, then this looks OK, but if yes, then the test should initiate playback. Maybe webgl-test-utils' startPlayingAndWaitForVideo helper function would be useful: https://cs.chromium.org/chromium/src/third_party/webgl/src/sdk/tests/js/webgl...
	31 } else {

	32 g_swapsBeforeAck--;

	33 window.requestAnimationFrame(waitForFinish);

	34 }

	35 }

	36 </script>

	37 </head>

	38 <body onload="main()">

	39 <div id="container" style="position:absolute; top:0px; left:0px">

	40 <video class="nomargin">

	41 <source src="../media/bear.mp4" type="video/mp4">

	42 </video>

	43 </div>

	44 </body>

	45 </html>

OLD	NEW

« no previous file with comments | « no previous file | content/test/data/gpu/pixel_video_vp9.html » ('j') | no next file with comments »