Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 2769063004: Revert of [debug] do not report unnecessary coverage data. (Closed)

Created:
3 years, 9 months ago by Michael Achenbach
Modified:
3 years, 9 months ago
Reviewers:
caseq, Yang, jgruber
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debug] do not report unnecessary coverage data. (patchset #4 id:60001 of https://codereview.chromium.org/2764073004/ ) Reason for revert: breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/14438 Original issue's description: > [debug] do not report unnecessary coverage data. > > Only include function ranges for with non-0 counts or if the immediate outer function has non-0 count. > > R=caseq@chromium.org, jgruber@chromium.org > BUG=v8:5808 > > Review-Url: https://codereview.chromium.org/2764073004 > Cr-Commit-Position: refs/heads/master@{#44079} > Committed: https://chromium.googlesource.com/v8/v8/+/a7577ede0b74967727895eba5e06dbe1d01fb56d TBR=caseq@chromium.org,jgruber@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5808 Review-Url: https://codereview.chromium.org/2769063004 Cr-Commit-Position: refs/heads/master@{#44080} Committed: https://chromium.googlesource.com/v8/v8/+/4e9ca1031dd5630c159de84d75c7529717c3bcab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -553 lines) Patch
M src/debug/debug-coverage.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug-coverage.cc View 3 chunks +1 line, -16 lines 0 comments Download
M test/inspector/cpu-profiler/coverage.js View 3 chunks +2 lines, -58 lines 0 comments Download
M test/inspector/cpu-profiler/coverage-expected.txt View 11 chunks +450 lines, -478 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [debug] do not report unnecessary coverage data.
3 years, 9 months ago (2017-03-23 21:03:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769063004/1
3 years, 9 months ago (2017-03-23 21:03:17 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 21:03:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4e9ca1031dd5630c159de84d75c7529717c...

Powered by Google App Engine
This is Rietveld 408576698