[debug] do not report unnecessary coverage data.

[debug] do not report unnecessary coverage data.

Only include function ranges for with non-0 counts or if the immediate outer function has non-0 count.

R=caseq@chromium.org, jgruber@chromium.org
BUG=v8:5808
Review-Url: https://codereview.chromium.org/2764073004
Cr-Original-Commit-Position: refs/heads/master@{#44079}
Committed: https://chromium.googlesource.com/v8/v8/+/a7577ede0b74967727895eba5e06dbe1d01fb56d
Review-Url: https://codereview.chromium.org/2764073004
Cr-Commit-Position: refs/heads/master@{#44120}
Committed: https://chromium.googlesource.com/v8/v8/+/f633c5f38333a41ebc3d94c86ce536ad33749e27

[Yang, 2017-03-22 09:01:09]

Description was changed from

==========
[debug] do not report unnecessary coverage data.

R=caseq@chromium.org, jgruber@chromium.org
BUG=v8:5808
==========

to

==========
[debug] do not report unnecessary coverage data.

Only include function ranges for with non-0 counts or if the immediate outer
function has non-0 count.

R=caseq@chromium.org, jgruber@chromium.org
BUG=v8:5808
==========

[Yang, 2017-03-22 09:01:23]

Please take a look.

[jgruber, 2017-03-22 09:52:21]

lgtm

[caseq, 2017-03-23 00:09:57]

lgtm

https://codereview.chromium.org/2764073004/diff/1/src/debug/debug-coverage.cc
File src/debug/debug-coverage.cc (right):

https://codereview.chromium.org/2764073004/diff/1/src/debug/debug-coverage.cc...
src/debug/debug-coverage.cc:137: std::vector<size_t> nesting;
nit: perhaps std::vector<const CoverageFunction*> for less indirection?

[Yang, 2017-03-23 07:43:16]

https://codereview.chromium.org/2764073004/diff/1/src/debug/debug-coverage.cc
File src/debug/debug-coverage.cc (right):

https://codereview.chromium.org/2764073004/diff/1/src/debug/debug-coverage.cc...
src/debug/debug-coverage.cc:137: std::vector<size_t> nesting;
On 2017/03/23 00:09:56, caseq wrote:
> nit: perhaps std::vector<const CoverageFunction*> for less indirection?

I considered that. However, std::vector reallocates and copies its content when
growing the backing store. Raw pointers into the backing store will then become
invalid.

[Yang, 2017-03-23 17:27:07]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-03-23 17:27:07]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org,
jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2764073004/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-23 17:27:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 17:54:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 17:54:18]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[Yang, 2017-03-23 17:58:15]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2017-03-23 17:58:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 18:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:05:31]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[Yang, 2017-03-23 19:44:58]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2017-03-23 19:45:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 20:07:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490298298484400,
"parent_rev": "b123ee34111f643fec6f7b662912deafd1165e3e", "commit_rev":
"a7577ede0b74967727895eba5e06dbe1d01fb56d"}

[commit-bot: I haz the power, 2017-03-23 20:07:39]

Description was changed from

==========
[debug] do not report unnecessary coverage data.

Only include function ranges for with non-0 counts or if the immediate outer
function has non-0 count.

R=caseq@chromium.org, jgruber@chromium.org
BUG=v8:5808
==========

to

==========
[debug] do not report unnecessary coverage data.

Only include function ranges for with non-0 counts or if the immediate outer
function has non-0 count.

R=caseq@chromium.org, jgruber@chromium.org
BUG=v8:5808

Review-Url: https://codereview.chromium.org/2764073004
Cr-Commit-Position: refs/heads/master@{#44079}
Committed:
https://chromium.googlesource.com/v8/v8/+/a7577ede0b74967727895eba5e06dbe1d01...
==========

[commit-bot: I haz the power, 2017-03-23 20:07:40]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/a7577ede0b74967727895eba5e06dbe1d01...

[Michael Achenbach, 2017-03-23 21:03:12]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2769063004/ by machenbach@chromium.org.

The reason for reverting is: breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[Yang, 2017-03-23 21:04:09]

On 2017/03/23 21:03:12, Michael Achenbach wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2769063004/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: breaks layout tests:
>
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

Andrey, seems like this change breaks some of your tests. How should we proceed?

[Yang, 2017-03-23 21:19:29]

Description was changed from

==========
[debug] do not report unnecessary coverage data.

Only include function ranges for with non-0 counts or if the immediate outer
function has non-0 count.

R=caseq@chromium.org, jgruber@chromium.org
BUG=v8:5808

Review-Url: https://codereview.chromium.org/2764073004
Cr-Commit-Position: refs/heads/master@{#44079}
Committed:
https://chromium.googlesource.com/v8/v8/+/a7577ede0b74967727895eba5e06dbe1d01...
==========

to

==========
[debug] do not report unnecessary coverage data.

Only include function ranges for with non-0 counts or if the immediate outer
function has non-0 count.

R=caseq@chromium.org, jgruber@chromium.org
BUG=v8:5808

Review-Url: https://codereview.chromium.org/2764073004
Cr-Commit-Position: refs/heads/master@{#44079}
Committed:
https://chromium.googlesource.com/v8/v8/+/a7577ede0b74967727895eba5e06dbe1d01...
==========

[Yang, 2017-03-24 08:05:38]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 08:05:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 08:06:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 08:06:51]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-03-24 17:59:27]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 17:59:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 18:24:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 18:24:23]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-03-24 18:26:02]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2017-03-24 18:26:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 18:27:41]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490379962644160,
"parent_rev": "5fdb5a148e7759b89d09ca5eac5a24af63bdd125", "commit_rev":
"f633c5f38333a41ebc3d94c86ce536ad33749e27"}

[commit-bot: I haz the power, 2017-03-24 18:27:48]

Description was changed from

==========
[debug] do not report unnecessary coverage data.

Only include function ranges for with non-0 counts or if the immediate outer
function has non-0 count.

R=caseq@chromium.org, jgruber@chromium.org
BUG=v8:5808

Review-Url: https://codereview.chromium.org/2764073004
Cr-Commit-Position: refs/heads/master@{#44079}
Committed:
https://chromium.googlesource.com/v8/v8/+/a7577ede0b74967727895eba5e06dbe1d01...
==========

to

==========
[debug] do not report unnecessary coverage data.

Only include function ranges for with non-0 counts or if the immediate outer
function has non-0 count.

R=caseq@chromium.org, jgruber@chromium.org
BUG=v8:5808

Review-Url: https://codereview.chromium.org/2764073004
Cr-Original-Commit-Position: refs/heads/master@{#44079}
Committed:
https://chromium.googlesource.com/v8/v8/+/a7577ede0b74967727895eba5e06dbe1d01...
Review-Url: https://codereview.chromium.org/2764073004
Cr-Commit-Position: refs/heads/master@{#44120}
Committed:
https://chromium.googlesource.com/v8/v8/+/f633c5f38333a41ebc3d94c86ce536ad337...
==========

[commit-bot: I haz the power, 2017-03-24 18:27:49]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/f633c5f38333a41ebc3d94c86ce536ad337...