Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: components/autofill/content/renderer/form_classifier.cc

Issue 2769023003: [Password Manager] Check node visibility with isFocusable instead of hasNonEmptyLayoutSize (Closed)
Patch Set: Added comment to IsWebElementVisible Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/form_classifier.cc
diff --git a/components/autofill/content/renderer/form_classifier.cc b/components/autofill/content/renderer/form_classifier.cc
index 4a4ea3e35c435609c88af930481bf1a34ba65f95..de6b29bd9d974603a7bc2d1a377db05b03bc2b67 100644
--- a/components/autofill/content/renderer/form_classifier.cc
+++ b/components/autofill/content/renderer/form_classifier.cc
@@ -91,7 +91,7 @@ bool FindCaptchaInImgElements(const blink::WebElement& form,
form.getElementsByHTMLTagName(kImageTag);
for (blink::WebElement element = img_elements.firstItem(); !element.isNull();
element = img_elements.nextItem()) {
- if (ingnore_invisible && !form_util::IsWebNodeVisible(element))
+ if (ingnore_invisible && !form_util::IsWebElementVisible(element))
continue;
if (FindTextFeaturesForClass(element, kCaptchaFeatures,
kNumberOfCaptchaFeatures)) {
@@ -161,7 +161,7 @@ bool FormContainsVisiblePasswordFields(const blink::WebFormElement& form) {
if (!input_element)
continue;
if (input_element->isPasswordField() &&
- form_util::IsWebNodeVisible(*input_element)) {
+ form_util::IsWebElementVisible(*input_element)) {
return true;
}
}
@@ -199,7 +199,7 @@ bool ClassifyFormAndFindGenerationField(const blink::WebFormElement& form,
if (IsHiddenElement(control_element))
continue;
if (ignore_invisible_elements) {
- if (!form_util::IsWebNodeVisible(control_element))
+ if (!form_util::IsWebElementVisible(control_element))
continue;
}

Powered by Google App Engine
This is Rietveld 408576698