[Password Manager] Check node visibility with isFocusable instead of hasNonEmptyLayoutSize

components/autofill/content/renderer/form_classifier.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/form_classifier.h"
 
 #include <algorithm>
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
@@ skipping 73 matching lines @@
 // Finds <img>'s inside |form| and checks if <img>'s attributes contains captcha
 // text features. Returns true, if at least one occurrence was found.
 bool FindCaptchaInImgElements(const blink::WebElement& form,
                               bool ingnore_invisible) {
   CR_DEFINE_STATIC_LOCAL(WebString, kImageTag, ("img"));
 
   blink::WebElementCollection img_elements =
       form.getElementsByHTMLTagName(kImageTag);
   for (blink::WebElement element = img_elements.firstItem(); !element.isNull();
        element = img_elements.nextItem()) {
-    if (ingnore_invisible && !form_util::IsWebNodeVisible(element))
+    if (ingnore_invisible && !form_util::IsWebElementVisible(element))
       continue;
     if (FindTextFeaturesForClass(element, kCaptchaFeatures,
                                  kNumberOfCaptchaFeatures)) {
       return true;
     }
   }
   return false;
 }
 
 // Finds signin and signup features in |element|'s attribute values. Sets to
@@ skipping 49 matching lines @@
 
 // Return true if |form| contains at least one visible password element.
 bool FormContainsVisiblePasswordFields(const blink::WebFormElement& form) {
   WebVector<WebFormControlElement> control_elements;
   form.getFormControlElements(control_elements);
   for (auto& control_element : control_elements) {
     const WebInputElement* input_element = toWebInputElement(&control_element);
     if (!input_element)
       continue;
     if (input_element->isPasswordField() &&
-        form_util::IsWebNodeVisible(*input_element)) {
+        form_util::IsWebElementVisible(*input_element)) {
       return true;
     }
   }
   return false;
 }
 
 }  // namespace
 
 bool ClassifyFormAndFindGenerationField(const blink::WebFormElement& form,
                                         base::string16* generation_field) {
@@ skipping 17 matching lines @@
                             &found_signup_text_features);
 
   std::vector<WebInputElement> passwords;
   WebVector<WebFormControlElement> control_elements;
   form.getFormControlElements(control_elements);
 
   for (const WebFormControlElement& control_element : control_elements) {
     if (IsHiddenElement(control_element))
       continue;
     if (ignore_invisible_elements) {
-      if (!form_util::IsWebNodeVisible(control_element))
+      if (!form_util::IsWebElementVisible(control_element))
         continue;
     }
 
     // If type="button" or "image", skip them, because it might be a link
     // to another form.
     if (IsButtonOrImageElement(control_element))
       continue;
 
     FindTextFeaturesInElement(control_element, &found_signin_text_features,
                               &found_signup_text_features);
@@ skipping 43 matching lines @@
       password_creation_field = passwords[1];
     else
       password_creation_field = passwords[0];
 
     *generation_field = password_creation_field.nameForAutofill().utf16();
     return true;
   }
   return false;
 }
 }