Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 2769023003: [Password Manager] Check node visibility with isFocusable instead of hasNonEmptyLayoutSize (Closed)
Patch Set: Added comment to IsWebElementVisible Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index cb66f89d99bb1527137d14d51024234d12ff65e1..f083ce62a9ff7cd85080c33fcdf43190ef993569 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -129,7 +129,7 @@ bool IsUnownedPasswordFormVisible(blink::WebFrame* frame,
const GURL& origin,
const FormData& form_data,
const FormsPredictionsMap& form_predictions) {
- if (!input_element.isNull() && form_util::IsWebNodeVisible(input_element))
+ if (!input_element.isNull() && form_util::IsWebElementVisible(input_element))
return true;
std::unique_ptr<PasswordForm> unowned_password_form(
@@ -202,7 +202,7 @@ bool FindFormInputElement(
if (found_input) {
// For change password form keep only the first password field entry.
if (does_password_field_has_ambigous_or_empty_name) {
- if (!form_util::IsWebNodeVisible((*result)[field_name])) {
+ if (!form_util::IsWebElementVisible((*result)[field_name])) {
// If a previously chosen field was invisible then take the current
// one.
(*result)[field_name] = input_element;

Powered by Google App Engine
This is Rietveld 408576698