Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2768923004: Remove redundant DCHECKs (Closed)

Created:
3 years, 9 months ago by matthewtff.asm
Modified:
3 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, oilpan-reviews, Mads Ager (chromium), net-reviews_chromium.org, bnc+watch_chromium.org, blink-reviews, kinuko+watch, kouhei+heap_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant DCHECKs BUG= Review-Url: https://codereview.chromium.org/2768923004 Cr-Commit-Position: refs/heads/master@{#459659} Committed: https://chromium.googlesource.com/chromium/src/+/c654a79ce1533215e2dcad41d5e623d8220d2dd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M components/sync/base/ordinal.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_protocol.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
matthewtff.asm
On 2017/03/24 16:09:44, matthewtff.asm wrote: > mailto:matthewtff@yandex-team.ru changed reviewers: > + mailto:haraken@chromium.org, mailto:maxbogue@chromium.org, mailto:zhongyi@chromium.org These ...
3 years, 9 months ago (2017-03-24 16:11:47 UTC) #3
haraken
WebKit LGTM
3 years, 9 months ago (2017-03-24 16:18:05 UTC) #4
maxbogue
components/sync lgtm
3 years, 9 months ago (2017-03-24 17:40:55 UTC) #5
Zhongyi Shi
net/ lgtm
3 years, 9 months ago (2017-03-24 23:30:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768923004/1
3 years, 9 months ago (2017-03-25 12:56:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/348186)
3 years, 9 months ago (2017-03-25 15:07:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768923004/1
3 years, 9 months ago (2017-03-25 21:58:22 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-25 22:29:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c654a79ce1533215e2dcad41d5e6...

Powered by Google App Engine
This is Rietveld 408576698