Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: net/spdy/spdy_protocol.h

Issue 2768923004: Remove redundant DCHECKs (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sync/base/ordinal.h ('k') | third_party/WebKit/Source/platform/heap/ThreadState.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file contains some protocol structures for use with SPDY 3 and HTTP 2 5 // This file contains some protocol structures for use with SPDY 3 and HTTP 2
6 // The SPDY 3 spec can be found at: 6 // The SPDY 3 spec can be found at:
7 // http://dev.chromium.org/spdy/spdy-protocol/spdy-protocol-draft3 7 // http://dev.chromium.org/spdy/spdy-protocol/spdy-protocol-draft3
8 8
9 #ifndef NET_SPDY_SPDY_PROTOCOL_H_ 9 #ifndef NET_SPDY_SPDY_PROTOCOL_H_
10 #define NET_SPDY_SPDY_PROTOCOL_H_ 10 #define NET_SPDY_SPDY_PROTOCOL_H_
(...skipping 578 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 589
590 // Moves description into description_store_, so caller doesn't need to 590 // Moves description into description_store_, so caller doesn't need to
591 // keep description live after constructing this SpdyGoAwayIR. 591 // keep description live after constructing this SpdyGoAwayIR.
592 SpdyGoAwayIR(SpdyStreamId last_good_stream_id, 592 SpdyGoAwayIR(SpdyStreamId last_good_stream_id,
593 SpdyErrorCode error_code, 593 SpdyErrorCode error_code,
594 std::string description); 594 std::string description);
595 595
596 ~SpdyGoAwayIR() override; 596 ~SpdyGoAwayIR() override;
597 SpdyStreamId last_good_stream_id() const { return last_good_stream_id_; } 597 SpdyStreamId last_good_stream_id() const { return last_good_stream_id_; }
598 void set_last_good_stream_id(SpdyStreamId last_good_stream_id) { 598 void set_last_good_stream_id(SpdyStreamId last_good_stream_id) {
599 DCHECK_LE(0u, last_good_stream_id);
600 DCHECK_EQ(0u, last_good_stream_id & ~kStreamIdMask); 599 DCHECK_EQ(0u, last_good_stream_id & ~kStreamIdMask);
601 last_good_stream_id_ = last_good_stream_id; 600 last_good_stream_id_ = last_good_stream_id;
602 } 601 }
603 SpdyErrorCode error_code() const { return error_code_; } 602 SpdyErrorCode error_code() const { return error_code_; }
604 void set_error_code(SpdyErrorCode error_code) { 603 void set_error_code(SpdyErrorCode error_code) {
605 // TODO(hkhalil): Check valid ranges of error_code? 604 // TODO(hkhalil): Check valid ranges of error_code?
606 error_code_ = error_code; 605 error_code_ = error_code;
607 } 606 }
608 607
609 const SpdyStringPiece& description() const { return description_; } 608 const SpdyStringPiece& description() const { return description_; }
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
902 SpdyFrameVisitor() {} 901 SpdyFrameVisitor() {}
903 virtual ~SpdyFrameVisitor() {} 902 virtual ~SpdyFrameVisitor() {}
904 903
905 private: 904 private:
906 DISALLOW_COPY_AND_ASSIGN(SpdyFrameVisitor); 905 DISALLOW_COPY_AND_ASSIGN(SpdyFrameVisitor);
907 }; 906 };
908 907
909 } // namespace net 908 } // namespace net
910 909
911 #endif // NET_SPDY_SPDY_PROTOCOL_H_ 910 #endif // NET_SPDY_SPDY_PROTOCOL_H_
OLDNEW
« no previous file with comments | « components/sync/base/ordinal.h ('k') | third_party/WebKit/Source/platform/heap/ThreadState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698