Add device-summary to bot-page

Add device-summary to bot-page

BUG=674118
Review-Url: https://codereview.chromium.org/2768893002
Committed: https://github.com/luci/luci-py/commit/67ec52b0fc09d8ba654f4ea12eab9d339a5bc35f

[kjlubick, 2017-03-22 18:27:25]

kjlubick@google.com changed reviewers:
+ stephana@google.com

[kjlubick, 2017-03-22 18:27:25]

https://screenshot.googleplex.com/BEoczWAtn6L

See it live at
https://2703-9e955a3-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/bot?...

[stephana, 2017-03-23 15:04:46]

https://codereview.chromium.org/2768893002/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/botpage/device-summary.html (right):

https://codereview.chromium.org/2768893002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/botpage/device-summary.html:88: 
Nit: no empty line between properties.

https://codereview.chromium.org/2768893002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/botpage/device-summary.html:100: for (var id in
this.state.devices) {
It's probably not an issue in this case, but in general I think it's still
suggest to use hasOwnProperty

for(var id in this.state.devices) {
    if (this.state.devices.hasOwnProperty(id)) {
       ...
    }
} 

See
http://stackoverflow.com/questions/684672/how-do-i-loop-through-or-enumerate-...

[kjlubick, 2017-03-23 15:26:21]

https://codereview.chromium.org/2768893002/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/botpage/device-summary.html (right):

https://codereview.chromium.org/2768893002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/botpage/device-summary.html:88: 
On 2017/03/23 at 15:04:46, stephana wrote:
> Nit: no empty line between properties.

done.

https://codereview.chromium.org/2768893002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/botpage/device-summary.html:100: for (var id in
this.state.devices) {
On 2017/03/23 at 15:04:46, stephana wrote:
> It's probably not an issue in this case, but in general I think it's still
suggest to use hasOwnProperty
> 
> for(var id in this.state.devices) {
>     if (this.state.devices.hasOwnProperty(id)) {
>        ...
>     }
> } 
> 
> See
http://stackoverflow.com/questions/684672/how-do-i-loop-through-or-enumerate-...

Done.

[stephana, 2017-03-23 18:14:22]

lgtm

[KevinL, 2017-03-23 19:04:08]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2017-03-23 19:04:08]

The CQ bit was checked by kjlubick@chromium.org

[KevinL, 2017-03-23 19:04:09]

lgtm

[commit-bot: I haz the power, 2017-03-23 19:04:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 19:08:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490295848810910,
"parent_rev": "e2ffa7a0c3b6e6e096aa54d6fcd20fa002895cea", "commit_rev":
"67ec52b0fc09d8ba654f4ea12eab9d339a5bc35f"}

[commit-bot: I haz the power, 2017-03-23 19:08:11]

Description was changed from

==========
Add device-summary to bot-page

BUG=674118
==========

to

==========
Add device-summary to bot-page

BUG=674118

Review-Url: https://codereview.chromium.org/2768893002
Committed:
https://github.com/luci/luci-py/commit/67ec52b0fc09d8ba654f4ea12eab9d339a5bc35f
==========

[commit-bot: I haz the power, 2017-03-23 19:08:12]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/67ec52b0fc09d8ba654f4ea12eab9d339a5bc35f