Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2765313002: Add proper natural sort to swarming UI (Closed)

Created:
3 years, 9 months ago by kjlubick
Modified:
3 years, 9 months ago
Reviewers:
stephana, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update package.json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -42 lines) Patch
M appengine/swarming/ui/.gitignore View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/swarming/ui/Makefile View 2 chunks +8 lines, -4 lines 0 comments Download
M appengine/swarming/ui/build/elements.html View 6 chunks +11 lines, -11 lines 0 comments Download
M appengine/swarming/ui/build/js/js.js View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/package.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list.html View 3 chunks +8 lines, -8 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list-demo.html View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/botpage/bot-page-demo.html View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/botpage/bot-page-summary.html View 2 chunks +15 lines, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html View 3 chunks +3 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-list-demo.html View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/ui/res/js/common.js View 1 chunk +0 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
kjlubick
Notice how build5 is in its proper place now: https://screenshot.googleplex.com/HicFCs0nM2W See it live on https://2703-9e955a3-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com
3 years, 9 months ago (2017-03-22 15:30:19 UTC) #2
M-A Ruel
naturalSort.js is missing.
3 years, 9 months ago (2017-03-22 15:58:46 UTC) #3
kjlubick
On 2017/03/22 at 15:58:46, maruel wrote: > naturalSort.js is missing. Good catch. build/js/natural-sort.js gets build ...
3 years, 9 months ago (2017-03-22 16:55:44 UTC) #4
M-A Ruel
lgtm
3 years, 9 months ago (2017-03-22 17:41:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765313002/20001
3 years, 9 months ago (2017-03-22 17:42:04 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 17:45:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/fdcf54c289f56e789f90a015edc4d8cbcfeb4ffa

Powered by Google App Engine
This is Rietveld 408576698