Chromium Code Reviews
DescriptionRevert of Allow status = 0 when XHR is completed in Audit.loadFileFromUrl(). (patchset #3 id:80001 of https://codereview.chromium.org/2766883002/ )
Reason for revert:
webaudio/Oscillator/osc-custom-sweep-snr.html is failing
See: https://crbug.com/704021
BUG=704021
Original issue's description:
> Allow status = 0 when XHR is completed in Audit.loadFileFromUrl().
>
> Currently Audit.loadFileFromUrl() checks the XHR status rigorously after
> its completion. This makes the XHR toward run-webkit-test server fail.
> To fix this issue, Audit.loadFileFromUrl() now accepts status = 0 in
> the |onload| handler.
>
> This change fixes the silent failure of XHR file fetching, thus enables
> some layout tests to do the actual buffer comparison within
> run-webkit-test.
>
> BUG=701813
> TEST=
> LayoutTests/webaudio/unit-tests/audit.html
> LayoutTests/webaudio/unit-tests/audit-failures.html
> LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html
> LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr.html
> LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr.html
> LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html
> LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html
> LayoutTests/webaudio/PeriodicWave/periodicwave-contexts.html
>
> Review-Url: https://codereview.chromium.org/2766883002
> Cr-Commit-Position: refs/heads/master@{#458621}
> Committed: https://chromium.googlesource.com/chromium/src/+/709962cdd9abacd997ca1a884bbccefbcb43c1ad
TBR=rtoy@chromium.org,hongchan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=701813
Review-Url: https://codereview.chromium.org/2768773002
Cr-Commit-Position: refs/heads/master@{#458654}
Committed: https://chromium.googlesource.com/chromium/src/+/cd641d3c73f24f48a5d0a66029b2fcd557f930ab
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|