Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 2768773002: Revert of Allow status = 0 when XHR is completed in Audit.loadFileFromUrl(). (Closed)

Created:
3 years, 9 months ago by horo
Modified:
3 years, 9 months ago
Reviewers:
Raymond Toy, hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow status = 0 when XHR is completed in Audit.loadFileFromUrl(). (patchset #3 id:80001 of https://codereview.chromium.org/2766883002/ ) Reason for revert: webaudio/Oscillator/osc-custom-sweep-snr.html is failing See: https://crbug.com/704021 BUG=704021 Original issue's description: > Allow status = 0 when XHR is completed in Audit.loadFileFromUrl(). > > Currently Audit.loadFileFromUrl() checks the XHR status rigorously after > its completion. This makes the XHR toward run-webkit-test server fail. > To fix this issue, Audit.loadFileFromUrl() now accepts status = 0 in > the |onload| handler. > > This change fixes the silent failure of XHR file fetching, thus enables > some layout tests to do the actual buffer comparison within > run-webkit-test. > > BUG=701813 > TEST= > LayoutTests/webaudio/unit-tests/audit.html > LayoutTests/webaudio/unit-tests/audit-failures.html > LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html > LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr.html > LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr.html > LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html > LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html > LayoutTests/webaudio/PeriodicWave/periodicwave-contexts.html > > Review-Url: https://codereview.chromium.org/2766883002 > Cr-Commit-Position: refs/heads/master@{#458621} > Committed: https://chromium.googlesource.com/chromium/src/+/709962cdd9abacd997ca1a884bbccefbcb43c1ad TBR=rtoy@chromium.org,hongchan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=701813 Review-Url: https://codereview.chromium.org/2768773002 Cr-Commit-Position: refs/heads/master@{#458654} Committed: https://chromium.googlesource.com/chromium/src/+/cd641d3c73f24f48a5d0a66029b2fcd557f930ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -60 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr.html View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr.html View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-contexts.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/resources/audit.js View 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js View 4 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html View 2 chunks +1 line, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
horo
Created Revert of Allow status = 0 when XHR is completed in Audit.loadFileFromUrl().
3 years, 9 months ago (2017-03-22 06:51:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768773002/1
3 years, 9 months ago (2017-03-22 06:52:32 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 07:05:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd641d3c73f24f48a5d0a66029b2...

Powered by Google App Engine
This is Rietveld 408576698