Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2768693002: Disable entire test testToolbarOmniboxTyping for iPad. (Closed)

Created:
3 years, 9 months ago by baxley
Modified:
3 years, 9 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable entire test testToolbarOmniboxTyping for iPad. This test was disabled for some typing, but not all on iPad. It is flaky on all typing of symbols. BUG=703855 Review-Url: https://codereview.chromium.org/2768693002 Cr-Commit-Position: refs/heads/master@{#458741} Committed: https://chromium.googlesource.com/chromium/src/+/9a81988319375a2112c38f2202571544a7522afd

Patch Set 1 #

Patch Set 2 : update comment #

Total comments: 2

Patch Set 3 : better variable name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M ios/chrome/browser/ui/toolbar/toolbar_egtest.mm View 1 2 2 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
baxley
3 years, 9 months ago (2017-03-21 22:51:12 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2768693002/diff/20001/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm File ios/chrome/browser/ui/toolbar/toolbar_egtest.mm (right): https://codereview.chromium.org/2768693002/diff/20001/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm#newcode440 ios/chrome/browser/ui/toolbar/toolbar_egtest.mm:440: NSString* cancelButton = l10n_util::GetNSString(IDS_CANCEL); Optional nit: s/cancelButton/cancelButtonText
3 years, 9 months ago (2017-03-21 22:53:25 UTC) #3
baxley
https://codereview.chromium.org/2768693002/diff/20001/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm File ios/chrome/browser/ui/toolbar/toolbar_egtest.mm (right): https://codereview.chromium.org/2768693002/diff/20001/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm#newcode440 ios/chrome/browser/ui/toolbar/toolbar_egtest.mm:440: NSString* cancelButton = l10n_util::GetNSString(IDS_CANCEL); On 2017/03/21 22:53:24, Eugene But ...
3 years, 9 months ago (2017-03-21 22:56:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768693002/40001
3 years, 9 months ago (2017-03-21 22:57:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 9 months ago (2017-03-22 00:59:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768693002/40001
3 years, 9 months ago (2017-03-22 14:17:20 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 14:23:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9a81988319375a2112c38f220257...

Powered by Google App Engine
This is Rietveld 408576698