Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: ios/chrome/browser/ui/toolbar/toolbar_egtest.mm

Issue 2768693002: Disable entire test testToolbarOmniboxTyping for iPad. (Closed)
Patch Set: better variable name Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
diff --git a/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm b/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
index a4aa7355b100a5b2506f83a4d317bce7b68ee919..35549a8af46f8308e3ba4a7eafef20725ab1ae5f 100644
--- a/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
+++ b/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
@@ -353,6 +353,10 @@ void SelectNewTabPagePanel(NewTabPage::PanelIdentifier panel_type) {
// Tests typing in the omnibox.
- (void)testToolbarOmniboxTyping {
+ // TODO(crbug.com/642559): Enable this test for iPad when typing bug is fixed.
+ if (IsIPadIdiom()) {
+ EARL_GREY_TEST_DISABLED(@"Disabled for iPad due to a simulator bug.");
+ }
SelectNewTabPagePanel(NewTabPage::kMostVisitedPanel);
id<GREYMatcher> locationbarButton = grey_allOf(
@@ -433,21 +437,15 @@ void SelectNewTabPagePanel(NewTabPage::PanelIdentifier panel_type) {
nil)]
assertWithMatcher:grey_sufficientlyVisible()];
- // TODO(crbug.com/642559): Enable these steps for iPad when typing bug
- // is fixed.
- if (IsIPadIdiom()) {
- EARL_GREY_TEST_DISABLED(@"Disabled for iPad due to a simulator bug.");
- } else {
- NSString* cancelButton = l10n_util::GetNSString(IDS_CANCEL);
- NSString* typingShield = @"Hide keyboard";
- NSString* clearText = IsIPadIdiom() ? typingShield : cancelButton;
+ NSString* cancelButtonText = l10n_util::GetNSString(IDS_CANCEL);
+ NSString* typingShield = @"Hide keyboard";
+ NSString* clearText = IsIPadIdiom() ? typingShield : cancelButtonText;
- [[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(clearText)]
- performAction:grey_tap()];
- [[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
- assertWithMatcher:chrome_test_util::OmniboxText("")];
+ [[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(clearText)]
+ performAction:grey_tap()];
+ [[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
+ assertWithMatcher:chrome_test_util::OmniboxText("")];
- SelectNewTabPagePanel(NewTabPage::kMostVisitedPanel);
- }
+ SelectNewTabPagePanel(NewTabPage::kMostVisitedPanel);
}
@end
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698