Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 2768683004: Revert of Lock out GCs while iterating over MediaStreamSource audio consumers. (Closed)

Created:
3 years, 9 months ago by sof
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, tommyw+watchlist_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Lock out GCs while iterating over MediaStreamSource audio consumers. (patchset #1 id:1 of https://codereview.chromium.org/2761463002/ ) Reason for revert: Revert this check, no longer needed (cf. https://bugs.chromium.org/p/chromium/issues/detail?id=682945#c48 ) Original issue's description: > Lock out GCs while iterating over MediaStreamSource audio consumers. > > Attempt to diagnose a crash condition by locking out main thread GCs > while the audio thread propagates consumeAudio() updates. > > R=haraken > BUG=682945 > > Review-Url: https://codereview.chromium.org/2761463002 > Cr-Commit-Position: refs/heads/master@{#457753} > Committed: https://chromium.googlesource.com/chromium/src/+/e78674d2467706fa8634f8542251591d1d358b57 TBR=haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=682945 Review-Url: https://codereview.chromium.org/2768683004 Cr-Commit-Position: refs/heads/master@{#458716} Committed: https://chromium.googlesource.com/chromium/src/+/a52c12d41a9376ffa733797e598b24cda44587fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sof
Created Revert of Lock out GCs while iterating over MediaStreamSource audio consumers.
3 years, 9 months ago (2017-03-22 09:51:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768683004/1
3 years, 9 months ago (2017-03-22 09:51:36 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-22 10:42:15 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 11:22:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a52c12d41a9376ffa733797e598b...

Powered by Google App Engine
This is Rietveld 408576698