Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2761463002: Lock out GCs while iterating over MediaStreamSource audio consumers. (Closed)

Created:
3 years, 9 months ago by sof
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, tommyw+watchlist_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lock out GCs while iterating over MediaStreamSource audio consumers. Attempt to diagnose a crash condition by locking out main thread GCs while the audio thread propagates consumeAudio() updates. R=haraken BUG=682945 Review-Url: https://codereview.chromium.org/2761463002 Cr-Commit-Position: refs/heads/master@{#457753} Committed: https://chromium.googlesource.com/chromium/src/+/e78674d2467706fa8634f8542251591d1d358b57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sof
please take a look. i'd like to try; we could make this more focused and ...
3 years, 9 months ago (2017-03-17 11:09:15 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-17 11:40:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761463002/1
3 years, 9 months ago (2017-03-17 13:44:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e78674d2467706fa8634f8542251591d1d358b57
3 years, 9 months ago (2017-03-17 13:48:48 UTC) #13
sof
3 years, 9 months ago (2017-03-22 09:51:09 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2768683004/ by sigbjornf@opera.com.

The reason for reverting is: Revert this check, no longer needed (cf.
https://bugs.chromium.org/p/chromium/issues/detail?id=682945#c48 ).

Powered by Google App Engine
This is Rietveld 408576698