Chromium Code Reviews
Description[Remoting Android] Fix race condition when initializing JniDisplayHandler
Previously weak_ptr_ is initialized after the PostTask call so sometimes
initialize() may be called earlier than weak_ptr_ being set, ending up with
a renderer_.SetDelegate(nullptr) call. In this case the renderer can't
report the dimension of the desktop frame to DesktopCanvas and DesktopCanvas
will just send broken transformation matrices, causing the renderer to render
only a black screen on the view.
This CL swaps two lines in JniDisplayHandler's ctor to fix this bug. I'll make
a follow up CL to guard the delegate in the renderer.
BUG=703240
Review-Url: https://codereview.chromium.org/2763773002
Cr-Commit-Position: refs/heads/master@{#458210}
(cherry picked from commit c99c48fc29b8e104b7552cdac7e28f8534c83bb7)
Review-Url: https://codereview.chromium.org/2768633002 .
Cr-Commit-Position: refs/branch-heads/3029@{#342}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/5dfef632beb0f174ea1d9822805c90dd44958a30
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||