[Remoting Android] Fix race condition when initializing JniDisplayHandler

[Remoting Android] Fix race condition when initializing JniDisplayHandler

Previously weak_ptr_ is initialized after the PostTask call so sometimes
initialize() may be called earlier than weak_ptr_ being set, ending up with
a renderer_.SetDelegate(nullptr) call. In this case the renderer can't
report the dimension of the desktop frame to DesktopCanvas and DesktopCanvas
will just send broken transformation matrices, causing the renderer to render
only a black screen on the view.

This CL swaps two lines in JniDisplayHandler's ctor to fix this bug. I'll make
a follow up CL to guard the delegate in the renderer.

BUG=703240
Review-Url: https://codereview.chromium.org/2763773002
Cr-Commit-Position: refs/heads/master@{#458210}
Committed: https://chromium.googlesource.com/chromium/src/+/c99c48fc29b8e104b7552cdac7e28f8534c83bb7

[Yuwei, 2017-03-20 22:01:20]

yuweih@chromium.org changed reviewers:
+ joedow@chromium.org, sergeyu@chromium.org

[Yuwei, 2017-03-20 22:01:20]

PTAL

Note that the ToT Android client crashes due to some other unrelated issue. I
just want to check this into the trunk first so that it can be later merged into
M58.

Thanks!

[joedow, 2017-03-20 22:05:24]

lgtm

[Yuwei, 2017-03-20 22:06:54]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2017-03-20 22:07:00]

On 2017/03/20 22:05:24, joedow wrote:
> lgtm

Thanks!

[Yuwei, 2017-03-20 22:07:01]

On 2017/03/20 22:05:24, joedow wrote:
> lgtm

Thanks!

[commit-bot: I haz the power, 2017-03-20 22:07:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:45:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490047614462960, "parent_rev":
"7943a2380f70fd5363ea44315c470b9a8459d122", "commit_rev":
"c99c48fc29b8e104b7552cdac7e28f8534c83bb7"}

[commit-bot: I haz the power, 2017-03-20 22:46:22]

Description was changed from

==========
[Remoting Android] Fix race condition when initializing JniDisplayHandler

Previously weak_ptr_ is initialized after the PostTask call so sometimes
initialize() may be called earlier than weak_ptr_ being set, ending up with
a renderer_.SetDelegate(nullptr) call. In this case the renderer can't
report the dimension of the desktop frame to DesktopCanvas and DesktopCanvas
will just send broken transformation matrices, causing the renderer to render
only a black screen on the view.

This CL swaps two lines in JniDisplayHandler's ctor to fix this bug. I'll make
a follow up CL to guard the delegate in the renderer.

BUG=703240
==========

to

==========
[Remoting Android] Fix race condition when initializing JniDisplayHandler

Previously weak_ptr_ is initialized after the PostTask call so sometimes
initialize() may be called earlier than weak_ptr_ being set, ending up with
a renderer_.SetDelegate(nullptr) call. In this case the renderer can't
report the dimension of the desktop frame to DesktopCanvas and DesktopCanvas
will just send broken transformation matrices, causing the renderer to render
only a black screen on the view.

This CL swaps two lines in JniDisplayHandler's ctor to fix this bug. I'll make
a follow up CL to guard the delegate in the renderer.

BUG=703240

Review-Url: https://codereview.chromium.org/2763773002
Cr-Commit-Position: refs/heads/master@{#458210}
Committed:
https://chromium.googlesource.com/chromium/src/+/c99c48fc29b8e104b7552cdac7e2...
==========

[commit-bot: I haz the power, 2017-03-20 22:46:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c99c48fc29b8e104b7552cdac7e2...