Add Device errors to bot-list status

Add Device errors to bot-list status

BUG=703149
Review-Url: https://codereview.chromium.org/2768553002
Committed: https://github.com/luci/luci-py/commit/9a3698537d93b2fc03f1f1ab7797307d7728ab12

[kjlubick, 2017-03-21 16:49:01]

kjlubick@google.com changed reviewers:
+ stephana@google.com

[kjlubick, 2017-03-21 16:49:02]

See it live at
https://2701-07473b8-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com

https://screenshot.googleplex.com/L0uGm0Qg4Zp

[stephana, 2017-03-21 17:33:39]

https://codereview.chromium.org/2768553002/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/botlist/bot-list.html (right):

https://codereview.chromium.org/2768553002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/botlist/bot-list.html:407: if (msg === "No
available devices.") {
This seems very fragile. Is there no stricter way (via field that has a fixed
set of values) to determine whether we need to look at other fields.

[kjlubick, 2017-03-21 19:56:15]

https://codereview.chromium.org/2768553002/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/botlist/bot-list.html (right):

https://codereview.chromium.org/2768553002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/botlist/bot-list.html:407: if (msg === "No
available devices.") {
On 2017/03/21 at 17:33:39, stephana wrote:
> This seems very fragile. Is there no stricter way (via field that has a fixed
set of values) to determine whether we need to look at other fields.


Removed the if statement, because I think it will always be useful to see the
device errors.

[stephana, 2017-03-21 20:55:29]

lgtm

[KevinL, 2017-03-21 20:56:38]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2017-03-21 20:56:38]

The CQ bit was checked by kjlubick@chromium.org

[KevinL, 2017-03-21 20:56:38]

lgtm

[commit-bot: I haz the power, 2017-03-21 20:56:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 21:00:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490129798205720,
"parent_rev": "07473b888fa5db145c5e8a490f4e8b8de10da7ae", "commit_rev":
"9a3698537d93b2fc03f1f1ab7797307d7728ab12"}

[commit-bot: I haz the power, 2017-03-21 21:00:10]

Description was changed from

==========
Add Device errors to bot-list status

BUG=703149
==========

to

==========
Add Device errors to bot-list status

BUG=703149

Review-Url: https://codereview.chromium.org/2768553002
Committed:
https://github.com/luci/luci-py/commit/9a3698537d93b2fc03f1f1ab7797307d7728ab12
==========

[commit-bot: I haz the power, 2017-03-21 21:00:11]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/9a3698537d93b2fc03f1f1ab7797307d7728ab12