Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2768553002: Add Device errors to bot-list status (Closed)

Created:
3 years, 9 months ago by kjlubick
Modified:
3 years, 9 months ago
Reviewers:
KevinL, stephana
CC:
borenet, chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove extra if #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 2 chunks +13 lines, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list.html View 1 1 chunk +12 lines, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list-shared-behavior.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
kjlubick
See it live at https://2701-07473b8-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com https://screenshot.googleplex.com/L0uGm0Qg4Zp
3 years, 9 months ago (2017-03-21 16:49:02 UTC) #2
stephana
https://codereview.chromium.org/2768553002/diff/1/appengine/swarming/ui/res/imp/botlist/bot-list.html File appengine/swarming/ui/res/imp/botlist/bot-list.html (right): https://codereview.chromium.org/2768553002/diff/1/appengine/swarming/ui/res/imp/botlist/bot-list.html#newcode407 appengine/swarming/ui/res/imp/botlist/bot-list.html:407: if (msg === "No available devices.") { This seems ...
3 years, 9 months ago (2017-03-21 17:33:39 UTC) #3
kjlubick
https://codereview.chromium.org/2768553002/diff/1/appengine/swarming/ui/res/imp/botlist/bot-list.html File appengine/swarming/ui/res/imp/botlist/bot-list.html (right): https://codereview.chromium.org/2768553002/diff/1/appengine/swarming/ui/res/imp/botlist/bot-list.html#newcode407 appengine/swarming/ui/res/imp/botlist/bot-list.html:407: if (msg === "No available devices.") { On 2017/03/21 ...
3 years, 9 months ago (2017-03-21 19:56:15 UTC) #4
stephana
lgtm
3 years, 9 months ago (2017-03-21 20:55:29 UTC) #5
KevinL
lgtm
3 years, 9 months ago (2017-03-21 20:56:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768553002/20001
3 years, 9 months ago (2017-03-21 20:56:49 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 21:00:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/9a3698537d93b2fc03f1f1ab7797307d7728ab12

Powered by Google App Engine
This is Rietveld 408576698