Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2217)

Unified Diff: appengine/swarming/ui/res/imp/botlist/bot-list.html

Issue 2768553002: Add Device errors to bot-list status (Closed)
Patch Set: Remove extra if Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/ui/res/imp/botlist/bot-list.html
diff --git a/appengine/swarming/ui/res/imp/botlist/bot-list.html b/appengine/swarming/ui/res/imp/botlist/bot-list.html
index cbdfdb360eb7a7dc2fa4f4edbf0ca199ea62e7da..3789bfb0ab0042588594f17df6852cbb95b5c204 100644
--- a/appengine/swarming/ui/res/imp/botlist/bot-list.html
+++ b/appengine/swarming/ui/res/imp/botlist/bot-list.html
@@ -404,6 +404,18 @@
if (msg === UNKNOWN || msg === "true" || msg === true) {
msg = this._attribute(bot, "error");
}
+ var errs = [];
+ // Show all the errors that are active on devices to make it more
+ // clear if this is a transient error (e.g. device is too hot)
+ // or if it is requires human interaction (e.g. device is unauthorized)
+ this._devices(bot).forEach(function(d){
+ if (d.state !== "available") {
+ errs.push(d.state);
+ }
+ });
+ if (errs.length) {
+ msg += " ["+errs.join(",")+"]";
+ }
return "Quarantined: " + msg;
}
return "Alive";
« no previous file with comments | « appengine/swarming/ui/build/elements.html ('k') | appengine/swarming/ui/res/imp/botlist/bot-list-shared-behavior.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698