Fix IdentifierContext for primary expressions. Also pass IdentifierContext to handleThisExpression …

pkg/front_end/lib/src/fasta/parser/identifier_context.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Information about the parser state which is passed to the listener at the
 /// time an identifier is encountered.
 ///
 /// This can be used by the listener to determine the context in which the
 /// identifier appears; that in turn can help the listener decide how to resolve
 /// the identifier (if the listener is doing resolution).
@@ skipping 231 matching lines @@
   /// invocation (e.g. `foo` in `f(foo: 0);`.
   static const namedArgumentReference =
       const IdentifierContext._('namedArgumentReference');
 
   /// Identifier is a name being declared by a local variable declaration.
   static const localVariableDeclaration = const IdentifierContext._(
       'localVariableDeclaration',
       inDeclaration: true);
 
   /// Identifier is a reference to a label (e.g. `foo` in `break foo;`).
-  static const labelReference =
-      const IdentifierContext._('labelReference', isScopeReference: true);
+  /// Labels have their own scope.
+  static const labelReference = const IdentifierContext._('labelReference');
 
   final String _name;
 
   /// Indicates whether the identifier represents a name which is being
   /// declared.
   final bool inDeclaration;
 
   /// Indicates whether the identifier is within a `library` or `part of`
   /// declaration.
   final bool inLibraryOrPartOfDeclaration;
@@ skipping 13 matching lines @@
   const IdentifierContext._(this._name,
       {this.inDeclaration: false,
       this.inLibraryOrPartOfDeclaration: false,
       this.inSymbol: false,
       this.isContinuation: false,
       this.isScopeReference: false,
       this.isBuiltInIdentifierAllowed: true});
 
   String toString() => _name;
 }