Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2768503002: [type-profile] Add test for fall-off return. (Closed)

Created:
3 years, 9 months ago by Franzi
Modified:
3 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[type-profile] Add test for fall-off return. Add a test case as reminder for future work. There is no return statement, therefore 'undefined' should be the type. R=mstarzinger@chromium.org BUG=v8:5935 Review-Url: https://codereview.chromium.org/2768503002 Cr-Commit-Position: refs/heads/master@{#44009} Committed: https://chromium.googlesource.com/v8/v8/+/71fe3dd8d2faade9b51f079775252ce0a7652410

Patch Set 1 #

Patch Set 2 : Add comment. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M test/message/type-profile/collect-type-profile.js View 1 3 chunks +14 lines, -15 lines 0 comments Download
M test/message/type-profile/collect-type-profile.out View 1 2 1 chunk +6 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
Franzi
Another test. PTAL. Thanks :)
3 years, 9 months ago (2017-03-21 14:02:38 UTC) #1
Michael Starzinger
LGTM. Thanks!
3 years, 9 months ago (2017-03-22 09:17:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768503002/40001
3 years, 9 months ago (2017-03-22 10:09:26 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 10:16:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/71fe3dd8d2faade9b51f079775252ce0a76...

Powered by Google App Engine
This is Rietveld 408576698