Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1671)

Issue 2765863002: [type-profile] Add test for return in try-finally. (Closed)

Created:
3 years, 9 months ago by Franzi
Modified:
3 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[type-profile] Add test for return in try-finally. Add a test case as reminder for future work. The return statement is in a try finally and is never used when returning. The type should not be collected. R=mstarzinger@chromium.org BUG=v8:5935 Review-Url: https://codereview.chromium.org/2765863002 Cr-Commit-Position: refs/heads/master@{#44006} Committed: https://chromium.googlesource.com/v8/v8/+/5cd870b4fff165cc06a324c6a765ff72b9f432a4

Patch Set 1 #

Patch Set 2 : Improve comment. #

Patch Set 3 : Fix expected output. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M test/message/type-profile/collect-type-profile.js View 1 1 chunk +15 lines, -0 lines 0 comments Download
M test/message/type-profile/collect-type-profile.out View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
Franzi
PTAL
3 years, 9 months ago (2017-03-21 13:50:03 UTC) #3
Michael Starzinger
LGTM. Thanks!
3 years, 9 months ago (2017-03-22 09:18:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765863002/20001
3 years, 9 months ago (2017-03-22 09:23:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/18953) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 9 months ago (2017-03-22 09:38:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765863002/40001
3 years, 9 months ago (2017-03-22 09:44:20 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 10:08:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/5cd870b4fff165cc06a324c6a765ff72b9f...

Powered by Google App Engine
This is Rietveld 408576698