Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 2768453002: [debug] use best effort coverage when enabling precise coverage. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
caseq, jgruber
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] use best effort coverage when enabling precise coverage. We used to clear invocation counts when enabling precise coverage. This is not necessary, and we could continue to use the existing invocation counts on the heap. The old behavior can be achieved by explicitly resetting the counts by polling coverage data. R=jgruber@chromium.org,caseq@chromium.org BUG=v8:5808 Review-Url: https://codereview.chromium.org/2768453002 Cr-Commit-Position: refs/heads/master@{#43964} Committed: https://chromium.googlesource.com/v8/v8/+/ed93e7c27b2c3f2ddd995fdc3a40b35341232e9f

Patch Set 1 #

Patch Set 2 : remove dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M src/debug/debug-coverage.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M src/feedback-vector.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/feedback-vector-inl.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M test/inspector/cpu-profiler/coverage-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
Yang
3 years, 9 months ago (2017-03-21 06:25:55 UTC) #1
jgruber
lgtm
3 years, 9 months ago (2017-03-21 08:22:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768453002/20001
3 years, 9 months ago (2017-03-21 08:29:08 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 08:55:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/ed93e7c27b2c3f2ddd995fdc3a40b353412...

Powered by Google App Engine
This is Rietveld 408576698