Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2765813002: [debug] refactor code coverage to use enum for mode. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] refactor code coverage to use enum for mode. This is in preparation of adding precise binary mode. BUG=v8:5808 Review-Url: https://codereview.chromium.org/2765813002 Cr-Commit-Position: refs/heads/master@{#43974} Committed: https://chromium.googlesource.com/v8/v8/+/fa3f8c6fb09f11393ce70e73747d508838ed0687

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : fix d8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -66 lines) Patch
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/d8.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/debug/debug-coverage.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/debug/debug-coverage.cc View 2 chunks +57 lines, -46 lines 0 comments Download
M src/debug/debug-interface.h View 2 chunks +9 lines, -1 line 0 comments Download
M src/feedback-vector.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M src/inspector/v8-profiler-agent-impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/isolate.h View 3 chunks +11 lines, -1 line 0 comments Download
M src/isolate.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (8 generated)
Yang
3 years, 9 months ago (2017-03-21 08:29:15 UTC) #2
jgruber
lgtm
3 years, 9 months ago (2017-03-21 08:33:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765813002/20001
3 years, 9 months ago (2017-03-21 09:19:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/33059) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, ...
3 years, 9 months ago (2017-03-21 09:23:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765813002/40001
3 years, 9 months ago (2017-03-21 10:42:04 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 11:08:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/fa3f8c6fb09f11393ce70e73747d508838e...

Powered by Google App Engine
This is Rietveld 408576698