[Bindings] Rename CachedAccessorCallback method in generated code

Rename CachedAccessorCallback methods in generated code

This method is used in creating function templates to get (or generate)
a property key, and this method itself is not registered as a callback function.
Hence, the name with 'Callback' suffix was confusing, and this CL changes
the name to be 'CachedPropertyKey' like getter functions.


Note:
On current trunk code, V8Window::documentCachedAccessorCallback()
is the only method which is actually renamed.


BUG=660281
Review-Url: https://codereview.chromium.org/2768393004
Cr-Commit-Position: refs/heads/master@{#459389}
Committed: https://chromium.googlesource.com/chromium/src/+/8f7af87790319208abf7f4554e32a868b91b478d

[peria, 2017-03-24 05:59:31]

Description was changed from

==========
Rename CachedPropertyCallback method in generated code


BUG=None
==========

to

==========
Rename CachedPropertyCallback method in generated code

This method is used in creating function templates to get (or generate)
a property key, and not used as a callback function called from V8 side.
So the name '...Callback' was confusing, and this CL changes the name
to be 'CachedPropertyKey' like getter functions.


BUG=660281
==========

[peria, 2017-03-24 06:01:53]

Description was changed from

==========
Rename CachedPropertyCallback method in generated code

This method is used in creating function templates to get (or generate)
a property key, and not used as a callback function called from V8 side.
So the name '...Callback' was confusing, and this CL changes the name
to be 'CachedPropertyKey' like getter functions.


BUG=660281
==========

to

==========
Rename CachedPropertyCallback method in generated code

This method is used in creating function templates to get (or generate)
a property key, and this method itself is not registered as a callback function.
Hence, the name with 'Callback' suffix was confusing, and this CL changes
the name to be 'CachedPropertyKey' like getter functions.


BUG=660281
==========

[peria, 2017-03-24 06:05:44]

Description was changed from

==========
Rename CachedPropertyCallback method in generated code

This method is used in creating function templates to get (or generate)
a property key, and this method itself is not registered as a callback function.
Hence, the name with 'Callback' suffix was confusing, and this CL changes
the name to be 'CachedPropertyKey' like getter functions.


BUG=660281
==========

to

==========
Rename CachedAccessorCallback methods in generated code

This method is used in creating function templates to get (or generate)
a property key, and this method itself is not registered as a callback function.
Hence, the name with 'Callback' suffix was confusing, and this CL changes
the name to be 'CachedPropertyKey' like getter functions.


Note:
On current trunk code, V8Window::documentCachedAccessorCallback()
is the only method which is actually renamed.


BUG=660281
==========

[peria, 2017-03-24 06:07:47]

peria@chromium.org changed reviewers:
+ bashi@chromium.org, haraken@chromium.org, yukishiino@chromium.org

[peria, 2017-03-24 06:07:47]

PTL

The change itself is trivial.
Other suggestions are also welcome.

thanks,

[bashi, 2017-03-24 06:11:03]

lgtm on my side and defer to yukishiino@ about the renaming.

[haraken, 2017-03-24 06:14:44]

We normally call a function that is called back by V8 a "callback". In that
sense, this is a callback.

Also if you want to rename it, you need to rename things in DOMConfiguration.cpp
as well.

[peria, 2017-03-24 06:31:13]

On 2017/03/24 06:14:44, haraken wrote:
> We normally call a function that is called back by V8 a "callback". In that
> sense, this is a callback.
> 

No, this method is never called back by nor passed to V8.
Its function pointer is passed around only in Blink process, and used to
create a v8::Private as a key of a private property.

> Also if you want to rename it, you need to rename things in
DOMConfiguration.cpp
> as well.

Yes, will do soon.

[haraken, 2017-03-24 06:33:35]

On 2017/03/24 06:31:13, peria (slow this week) wrote:
> On 2017/03/24 06:14:44, haraken wrote:
> > We normally call a function that is called back by V8 a "callback". In that
> > sense, this is a callback.
> > 
> 
> No, this method is never called back by nor passed to V8.
> Its function pointer is passed around only in Blink process, and used to
> create a v8::Private as a key of a private property.

Isn't it passed to V8 (to let V8 know the private property key)?

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/bindings/core/...


> 
> > Also if you want to rename it, you need to rename things in
> DOMConfiguration.cpp
> > as well.
> 
> Yes, will do soon.

[haraken, 2017-03-24 06:34:12]

On 2017/03/24 06:33:35, haraken wrote:
> On 2017/03/24 06:31:13, peria (slow this week) wrote:
> > On 2017/03/24 06:14:44, haraken wrote:
> > > We normally call a function that is called back by V8 a "callback". In
that
> > > sense, this is a callback.
> > > 
> > 
> > No, this method is never called back by nor passed to V8.
> > Its function pointer is passed around only in Blink process, and used to
> > create a v8::Private as a key of a private property.
> 
> Isn't it passed to V8 (to let V8 know the private property key)?
> 
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/bindings/core/...
> 
> 
> > 
> > > Also if you want to rename it, you need to rename things in
> > DOMConfiguration.cpp
> > > as well.
> > 
> > Yes, will do soon.

Ah, got it. Blink is just passing the key itself to V8, not the callback. LGTM
:)

[peria, 2017-03-24 06:39:26]

On 2017/03/24 06:34:12, haraken wrote:
> On 2017/03/24 06:33:35, haraken wrote:
> > On 2017/03/24 06:31:13, peria (slow this week) wrote:
> > > On 2017/03/24 06:14:44, haraken wrote:
> > > > We normally call a function that is called back by V8 a "callback". In
> that
> > > > sense, this is a callback.
> > > > 
> > > 
> > > No, this method is never called back by nor passed to V8.
> > > Its function pointer is passed around only in Blink process, and used to
> > > create a v8::Private as a key of a private property.
> > 
> > Isn't it passed to V8 (to let V8 know the private property key)?
> > 
> >
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/bindings/core/...
> > 
> > 
> > > 
> > > > Also if you want to rename it, you need to rename things in
> > > DOMConfiguration.cpp
> > > > as well.
> > > 
> > > Yes, will do soon.
> 
> Ah, got it. Blink is just passing the key itself to V8, not the callback. LGTM
> :)

Yes, I forgot to write about it in the message.

[Yuki, 2017-03-24 07:00:30]

LGTM.

https://codereview.chromium.org/2768393004/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl (right):

https://codereview.chromium.org/2768393004/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl:249: {% macro
attribute_cache_property_key(attribute) %}
Should this be attribute_cache"d"_property_key to be consistent?

[peria, 2017-03-24 08:44:28]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[peria, 2017-03-24 08:44:34]

https://codereview.chromium.org/2768393004/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl (right):

https://codereview.chromium.org/2768393004/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl:249: {% macro
attribute_cache_property_key(attribute) %}
On 2017/03/24 07:00:29, Yuki wrote:
> Should this be attribute_cache"d"_property_key to be consistent?

Done.

[commit-bot: I haz the power, 2017-03-24 08:44:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-03-24 08:44:44]

The CQ bit was unchecked by peria@chromium.org

[peria, 2017-03-24 08:44:45]

The CQ bit was checked by peria@chromium.org

[peria, 2017-03-24 08:44:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yukishiino@chromium.org, bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/2768393004/#ps20001
(title: ".")

[commit-bot: I haz the power, 2017-03-24 08:44:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 09:14:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:14:10]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[peria, 2017-03-24 09:31:16]

The CQ bit was checked by peria@chromium.org

[peria, 2017-03-24 09:31:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yukishiino@chromium.org, bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/2768393004/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-03-24 09:31:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 09:38:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:38:23]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[peria, 2017-03-24 09:46:21]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:46:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 11:26:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490348781616710,
"parent_rev": "24b165fba78663e400aa8ab86f31201cf1fbb005", "commit_rev":
"8f7af87790319208abf7f4554e32a868b91b478d"}

[commit-bot: I haz the power, 2017-03-24 11:27:10]

Description was changed from

==========
Rename CachedAccessorCallback methods in generated code

This method is used in creating function templates to get (or generate)
a property key, and this method itself is not registered as a callback function.
Hence, the name with 'Callback' suffix was confusing, and this CL changes
the name to be 'CachedPropertyKey' like getter functions.


Note:
On current trunk code, V8Window::documentCachedAccessorCallback()
is the only method which is actually renamed.


BUG=660281
==========

to

==========
Rename CachedAccessorCallback methods in generated code

This method is used in creating function templates to get (or generate)
a property key, and this method itself is not registered as a callback function.
Hence, the name with 'Callback' suffix was confusing, and this CL changes
the name to be 'CachedPropertyKey' like getter functions.


Note:
On current trunk code, V8Window::documentCachedAccessorCallback()
is the only method which is actually renamed.


BUG=660281

Review-Url: https://codereview.chromium.org/2768393004
Cr-Commit-Position: refs/heads/master@{#459389}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f7af87790319208abf7f4554e32...
==========

[commit-bot: I haz the power, 2017-03-24 11:27:12]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8f7af87790319208abf7f4554e32...