Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

Issue 2768393004: [Bindings] Rename CachedAccessorCallback method in generated code (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
index 21c784a30768a62284dcb59b8fca91e65532efba..c4826362fc0bf1e58c88e5ebcfcf6dc89a1bc876 100644
--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
@@ -77,11 +77,7 @@ static void (*{{method.name}}MethodForPartialInterface)(const v8::FunctionCallba
{##############################################################################}
{# Attributes #}
-{% from 'attributes.cpp.tmpl' import constructor_getter_callback,
- attribute_getter, attribute_getter_callback,
- attribute_setter, attribute_setter_callback,
- attribute_cache_property_callback,
- with context %}
+{% from 'attributes.cpp.tmpl' import attribute_getter, attribute_setter with context %}
{% for attribute in attributes %}
{% for world_suffix in attribute.world_suffixes %}
{% if not attribute.has_custom_getter and not attribute.constructor_type %}
@@ -179,14 +175,14 @@ static const struct {
{% for constant in constants | has_special_getter %}
{{constant_getter_callback(constant)}}
{% endfor %}
+
{# Attributes #}
{% from 'attributes.cpp.tmpl' import constructor_getter_callback,
attribute_getter_callback, attribute_setter_callback,
- attribute_cache_property_callback,
- with context %}
+ attribute_cached_property_key with context %}
{% for attribute in attributes %}
{% if attribute.is_cached_accessor %}
-{{attribute_cache_property_callback(attribute)}}
+{{attribute_cached_property_key(attribute)}}
{% endif %}
{% for world_suffix in attribute.world_suffixes %}
{% if not attribute.constructor_type %}

Powered by Google App Engine
This is Rietveld 408576698