Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Issue 2768393002: Adding first_event_time and last_event_time to LatencyInfo mojom. (Closed)

Created:
3 years, 9 months ago by mfomitchev
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez, tdresser
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding first_event_time and last_event_time to LatencyInfo mojom. These are used by RenderWidgetHostLatencyTracker. Legacy Chrome IPC serializes them, and so should Mojo. BUG=686865 Review-Url: https://codereview.chromium.org/2768393002 Cr-Commit-Position: refs/heads/master@{#459228} Committed: https://chromium.googlesource.com/chromium/src/+/3540cc14cd0b86a200aaedb2ef7fe024978aa98d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M ui/events/mojo/latency_info.mojom View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/mojo/latency_info_struct_traits.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/mojo/latency_info_struct_traits.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
mfomitchev
+tdresser for owner review +tsepez for security review
3 years, 9 months ago (2017-03-23 20:14:41 UTC) #4
Tom Sepez
lgtm
3 years, 9 months ago (2017-03-23 20:40:43 UTC) #7
tdresser
LGTM
3 years, 9 months ago (2017-03-23 21:02:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768393002/1
3 years, 9 months ago (2017-03-23 21:04:10 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 21:29:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3540cc14cd0b86a200aaedb2ef7f...

Powered by Google App Engine
This is Rietveld 408576698