CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1490400901003180, "parent_rev": "345a3681405a39f7ec3a675cc05457e04e708118", "commit_rev": "f88026ebc232158b4f1f36bb76bde4a855d5b6ef"}
3 years, 9 months ago
(2017-03-25 02:19:23 UTC)
#6
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490400901003180, "parent_rev":
"345a3681405a39f7ec3a675cc05457e04e708118", "commit_rev":
"f88026ebc232158b4f1f36bb76bde4a855d5b6ef"}
commit-bot: I haz the power
Description was changed from ========== Set default document urls to 'about:blank'. The patch ensures that ...
3 years, 9 months ago
(2017-03-25 02:20:11 UTC)
#7
Message was sent while issue was closed.
Description was changed from
==========
Set default document urls to 'about:blank'.
The patch ensures that the document urls are set to 'about:blank', as is
specified in [1], if a url has not been specified. It fixes the tests in
[2] and [3].
The functionality is implemented by binding the document urls to
'about:blank' if m_url is empty. To achieve this behavior the
Document::urlForBinding() function was added. The choice for a binding
was made rather than not using an intial value of 'about:blank' for the
document urls, as other parts of the code rely on the document urls
initially being empty.
More details regarding the binding can be found under:
https://codereview.chromium.org/2749803003/#msg37
Additionally the platform specific dom-interfaces test have been
removed, as they were identical, making platform specific expectations
superfluous. There is now a single interfaces test located at
third_party/WebKit/LayoutTests/external/wpt/dom/interfaces.html
[1] https://dom.spec.whatwg.org/#interface-document
[2] http://w3c-test.org/dom/nodes/DOMImplementation-createDocument.html
[3] http://w3c-test.org/dom/nodes/DOMImplementation-createHTMLDocument.html
BUG=563986
==========
to
==========
Set default document urls to 'about:blank'.
The patch ensures that the document urls are set to 'about:blank', as is
specified in [1], if a url has not been specified. It fixes the tests in
[2] and [3].
The functionality is implemented by binding the document urls to
'about:blank' if m_url is empty. To achieve this behavior the
Document::urlForBinding() function was added. The choice for a binding
was made rather than not using an intial value of 'about:blank' for the
document urls, as other parts of the code rely on the document urls
initially being empty.
More details regarding the binding can be found under:
https://codereview.chromium.org/2749803003/#msg37
Additionally the platform specific dom-interfaces test have been
removed, as they were identical, making platform specific expectations
superfluous. There is now a single interfaces test located at
third_party/WebKit/LayoutTests/external/wpt/dom/interfaces.html
[1] https://dom.spec.whatwg.org/#interface-document
[2] http://w3c-test.org/dom/nodes/DOMImplementation-createDocument.html
[3] http://w3c-test.org/dom/nodes/DOMImplementation-createHTMLDocument.html
BUG=563986
Review-Url: https://codereview.chromium.org/2768373005
Cr-Commit-Position: refs/heads/master@{#459624}
Committed:
https://chromium.googlesource.com/chromium/src/+/f88026ebc232158b4f1f36bb76bd...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f88026ebc232158b4f1f36bb76bde4a855d5b6ef
3 years, 9 months ago
(2017-03-25 02:20:13 UTC)
#8
Issue 2768373005: Set default document urls to 'about:blank'.
(Closed)
Created 3 years, 9 months ago by MartinRogalla
Modified 3 years, 9 months ago
Reviewers: tkent
Base URL:
Comments: 0