Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2768373005: Set default document urls to 'about:blank'. (Closed)

Created:
3 years, 9 months ago by MartinRogalla
Modified:
3 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set default document urls to 'about:blank'. The patch ensures that the document urls are set to 'about:blank', as is specified in [1], if a url has not been specified. It fixes the tests in [2] and [3]. The functionality is implemented by binding the document urls to 'about:blank' if m_url is empty. To achieve this behavior the Document::urlForBinding() function was added. The choice for a binding was made rather than not using an intial value of 'about:blank' for the document urls, as other parts of the code rely on the document urls initially being empty. More details regarding the binding can be found under: https://codereview.chromium.org/2749803003/#msg37 Additionally the platform specific dom-interfaces test have been removed, as they were identical, making platform specific expectations superfluous. There is now a single interfaces test located at third_party/WebKit/LayoutTests/external/wpt/dom/interfaces.html [1] https://dom.spec.whatwg.org/#interface-document [2] http://w3c-test.org/dom/nodes/DOMImplementation-createDocument.html [3] http://w3c-test.org/dom/nodes/DOMImplementation-createHTMLDocument.html BUG=563986 Review-Url: https://codereview.chromium.org/2768373005 Cr-Commit-Position: refs/heads/master@{#459624} Committed: https://chromium.googlesource.com/chromium/src/+/f88026ebc232158b4f1f36bb76bde4a855d5b6ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -6325 lines) Patch
D third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi02.js View 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi02.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi03.js View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi03.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentgetdocumenturi03-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentsetdocumenturi03.js View 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentsetdocumenturi03.xhtml View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/documentsetdocumenturi03-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodegetbaseuri02.js View 1 chunk +0 lines, -119 lines 0 comments Download
D third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodegetbaseuri02.xhtml View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodegetbaseuri02-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/DOMImplementation-createDocument-expected.txt View 6 chunks +91 lines, -91 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/dom/nodes/DOMImplementation-createHTMLDocument-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Node-cloneNode-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Node-properties-expected.txt View 1 chunk +0 lines, -703 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/document-attribute-js-null.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/document-attribute-js-null-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/dom/interfaces-expected.txt View 1 chunk +0 lines, -1613 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/dom/interfaces-expected.txt View 1 chunk +0 lines, -1613 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/external/wpt/dom/interfaces-expected.txt View 1 chunk +0 lines, -1613 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
MartinRogalla
3 years, 9 months ago (2017-03-24 22:30:18 UTC) #2
tkent
lgtm
3 years, 9 months ago (2017-03-25 00:15:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768373005/1
3 years, 9 months ago (2017-03-25 00:15:30 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-25 02:20:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f88026ebc232158b4f1f36bb76bd...

Powered by Google App Engine
This is Rietveld 408576698