Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9134)

Unified Diff: chrome/browser/ui/apps/app_info_dialog.h

Issue 276833002: Make the App Info Dialog appear modal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added new browser test Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/apps/app_info_dialog.h
diff --git a/chrome/browser/ui/apps/app_info_dialog.h b/chrome/browser/ui/apps/app_info_dialog.h
index 91820784b3b5c5412338b3630168746c3dcf4029..4cafcc92ce7a2d5002921aa42c529edfe9e4b7fe 100644
--- a/chrome/browser/ui/apps/app_info_dialog.h
+++ b/chrome/browser/ui/apps/app_info_dialog.h
@@ -5,7 +5,7 @@
#ifndef CHROME_BROWSER_UI_APPS_APP_INFO_DIALOG_H_
#define CHROME_BROWSER_UI_APPS_APP_INFO_DIALOG_H_
-#include "base/callback.h"
+#include "base/callback_forward.h"
#include "ui/gfx/native_widget_types.h"
class Profile;
@@ -13,10 +13,14 @@ class Profile;
namespace extensions {
class Extension;
}
+namespace gfx {
tapted 2014/05/23 02:09:21 nit: blank line before
sashab 2014/05/23 06:10:21 Done.
+class Rect;
+}
// Shows the chrome app information dialog box.
// |close_callback| may be null.
void ShowAppInfoDialog(gfx::NativeWindow parent_window,
+ gfx::Rect dialog_widget_bounds,
tapted 2014/05/23 02:09:21 nit: const gfx::Rect& dialog_widget_bounds,
sashab 2014/05/23 06:10:21 Done.
Profile* profile,
const extensions::Extension* app,
const base::Closure& close_callback);

Powered by Google App Engine
This is Rietveld 408576698