chrome/browser/ui/apps/app_info_dialog.h - Issue 276833002: Make the App Info Dialog appear modal

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/apps/app_info_dialog.h

Issue 276833002: Make the App Info Dialog appear modal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added new browser test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/app_list/app_list_service_views_browsertest.cc ('K') | « chrome/browser/ui/app_list/search/app_result.cc ('k') | chrome/browser/ui/ash/app_list/app_list_controller_ash.h » ('j') | ui/app_list/views/app_list_view.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_APPS_APP_INFO_DIALOG_H_	5 #ifndef CHROME_BROWSER_UI_APPS_APP_INFO_DIALOG_H_

6 #define CHROME_BROWSER_UI_APPS_APP_INFO_DIALOG_H_	6 #define CHROME_BROWSER_UI_APPS_APP_INFO_DIALOG_H_

7	7

8 #include "base/callback.h"	8 #include "base/callback_forward.h"

9 #include "ui/gfx/native_widget_types.h"	9 #include "ui/gfx/native_widget_types.h"

10	10

11 class Profile;	11 class Profile;

12	12

13 namespace extensions {	13 namespace extensions {

14 class Extension;	14 class Extension;

15 }	15 }

	16 namespace gfx {
	tapted 2014/05/23 02:09:21 nit: blank line before nit: blank line before sashab 2014/05/23 06:10:21 Done. Show quoted text On 2014/05/23 02:09:21, tapted wrote: > nit: blank line before Done.
	17 class Rect;

	18 }

16	19

17 // Shows the chrome app information dialog box.	20 // Shows the chrome app information dialog box.

18 // \|close_callback\| may be null.	21 // \|close_callback\| may be null.

19 void ShowAppInfoDialog(gfx::NativeWindow parent_window,	22 void ShowAppInfoDialog(gfx::NativeWindow parent_window,

	23 gfx::Rect dialog_widget_bounds,
	tapted 2014/05/23 02:09:21 nit: const gfx::Rect& dialog_widget_bounds, nit: const gfx::Rect& dialog_widget_bounds, sashab 2014/05/23 06:10:21 Done. Show quoted text On 2014/05/23 02:09:21, tapted wrote: > nit: const gfx::Rect& dialog_widget_bounds, Done.
20 Profile* profile,	24 Profile* profile,

21 const extensions::Extension* app,	25 const extensions::Extension* app,

22 const base::Closure& close_callback);	26 const base::Closure& close_callback);

23	27

24 #endif // CHROME_BROWSER_UI_APPS_APP_INFO_DIALOG_H_	28 #endif // CHROME_BROWSER_UI_APPS_APP_INFO_DIALOG_H_

OLD	NEW