Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/app_list/search/app_result.cc

Issue 276833002: Make the App Info Dialog appear modal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added new browser test Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/app_list/app_list_service_views_browsertest.cc ('K') | « chrome/browser/ui/app_list/extension_uninstaller.cc ('k') | chrome/browser/ui/apps/app_info_dialog.h » ('j') | chrome/browser/ui/apps/app_info_dialog.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/search/app_result.cc
diff --git a/chrome/browser/ui/app_list/search/app_result.cc b/chrome/browser/ui/app_list/search/app_result.cc
index 247c8289ddd1f4c8ebf98f56addee1e0c7dc812b..852423db303cd6a3a6b2808f74613ea06acd9c0b 100644
--- a/chrome/browser/ui/app_list/search/app_result.cc
+++ b/chrome/browser/ui/app_list/search/app_result.cc
@@ -139,7 +139,7 @@ bool AppResult::RunExtensionEnableFlow() {
return false;
if (!extension_enable_flow_) {
- controller_->OnShowExtensionPrompt();
+ controller_->OnShowChildDialog();
extension_enable_flow_.reset(new ExtensionEnableFlow(
profile_, app_id_, this));
@@ -171,7 +171,7 @@ void AppResult::ExecuteLaunchCommand(int event_flags) {
void AppResult::ExtensionEnableFlowFinished() {
extension_enable_flow_.reset();
- controller_->OnCloseExtensionPrompt();
+ controller_->OnCloseChildDialog();
// Automatically open app after enabling.
Open(ui::EF_NONE);
@@ -179,7 +179,7 @@ void AppResult::ExtensionEnableFlowFinished() {
void AppResult::ExtensionEnableFlowAborted(bool user_initiated) {
extension_enable_flow_.reset();
- controller_->OnCloseExtensionPrompt();
+ controller_->OnCloseChildDialog();
}
void AppResult::OnExtensionLoaded(const extensions::Extension* extension) {
« chrome/browser/ui/app_list/app_list_service_views_browsertest.cc ('K') | « chrome/browser/ui/app_list/extension_uninstaller.cc ('k') | chrome/browser/ui/apps/app_info_dialog.h » ('j') | chrome/browser/ui/apps/app_info_dialog.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698