[wasm] Implement wasm x64 I16x8 Ops

[wasm] Implement wasm x64 I16x8 Ops
 - Add I16x8 Splat, ExtractLane, ReplaceLane, shift ops, Some BinOps and compare ops
 - Add pshufhw, pshuflw in the assembler, disassembler
 - Fix incorrect modrm for pextrw, this bug disregards the register allocated and always makes pextrw use rax. 
 - Fix pextrw disasm to take the 0 - 7 bits of the immediate instead of 0 - 3. 
 - Pextrw, pinsrw are in the assembler use 128 bit encodings, pextrw, pinsrw in the disassembler use legacy encodings, fix inconsistencies causing weird code gen when --print-code is used.

Review-Url: https://codereview.chromium.org/2767983002
Cr-Commit-Position: refs/heads/master@{#44664}
Committed: https://chromium.googlesource.com/v8/v8/+/c8c03c150d2add866c09bf2aa866c6b4ed585b08

[gdeepti, 2017-03-22 18:17:32]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 18:17:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 18:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 18:33:34]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[gdeepti, 2017-04-04 21:40:27]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 21:40:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-04-04 21:56:08]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 21:56:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-04-04 22:11:04]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 22:11:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 22:28:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 22:28:05]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[gdeepti, 2017-04-06 21:19:27]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 21:19:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 22:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 22:04:11]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-04-12 07:30:15]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 07:30:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 07:31:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 07:31:54]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/20868)

[gdeepti, 2017-04-12 07:56:07]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 07:56:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 08:22:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 08:22:19]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-04-12 22:48:52]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 22:49:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 23:19:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 23:19:31]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-04-12 23:22:56]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 23:23:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-04-12 23:35:34]

Description was changed from

==========
Add Int16x8 Ops
==========

to

==========
[wasm] Implement x64 wasm I16x8 Ops
 - Add I16x8 Splat, ExtractLane, ReplaceLane, shift ops, Some BinOps and compare
ops
 - Add pshufhw, pshuflw in the assembler, disassembler
 - Fix incorrect modrm for pextrw, this bug disregards the register allocated
and always makes pextrw use rax. 
 - Fix pextrw disasm to take the 0 - 7 bits of the immediate instead of 0 - 3. 
 - Pextrw, pinsrw are in the assembler use 128 bit encodings, pextrw, pinsrw in
the disassembler use legacy encodings, fix inconsistencies causing weird code
gen when --print-code is used. 

 - 
 -
==========

[gdeepti, 2017-04-12 23:35:34]

gdeepti@chromium.org changed reviewers:
+ bbudge@chromium.org, bmeurer@chromium.org, bradnelson@chromium.org,
jing.bao@intel.com

[gdeepti, 2017-04-12 23:35:57]

Description was changed from

==========
[wasm] Implement x64 wasm I16x8 Ops
 - Add I16x8 Splat, ExtractLane, ReplaceLane, shift ops, Some BinOps and compare
ops
 - Add pshufhw, pshuflw in the assembler, disassembler
 - Fix incorrect modrm for pextrw, this bug disregards the register allocated
and always makes pextrw use rax. 
 - Fix pextrw disasm to take the 0 - 7 bits of the immediate instead of 0 - 3. 
 - Pextrw, pinsrw are in the assembler use 128 bit encodings, pextrw, pinsrw in
the disassembler use legacy encodings, fix inconsistencies causing weird code
gen when --print-code is used. 

 - 
 -
==========

to

==========
[wasm] Implement x64 wasm I16x8 Ops
 - Add I16x8 Splat, ExtractLane, ReplaceLane, shift ops, Some BinOps and compare
ops
 - Add pshufhw, pshuflw in the assembler, disassembler
 - Fix incorrect modrm for pextrw, this bug disregards the register allocated
and always makes pextrw use rax. 
 - Fix pextrw disasm to take the 0 - 7 bits of the immediate instead of 0 - 3. 
 - Pextrw, pinsrw are in the assembler use 128 bit encodings, pextrw, pinsrw in
the disassembler use legacy encodings, fix inconsistencies causing weird code
gen when --print-code is used.
==========

[gdeepti, 2017-04-12 23:37:02]

Description was changed from

==========
[wasm] Implement x64 wasm I16x8 Ops
 - Add I16x8 Splat, ExtractLane, ReplaceLane, shift ops, Some BinOps and compare
ops
 - Add pshufhw, pshuflw in the assembler, disassembler
 - Fix incorrect modrm for pextrw, this bug disregards the register allocated
and always makes pextrw use rax. 
 - Fix pextrw disasm to take the 0 - 7 bits of the immediate instead of 0 - 3. 
 - Pextrw, pinsrw are in the assembler use 128 bit encodings, pextrw, pinsrw in
the disassembler use legacy encodings, fix inconsistencies causing weird code
gen when --print-code is used.
==========

to

==========
[wasm] Implement wasm x64 I16x8 Ops
 - Add I16x8 Splat, ExtractLane, ReplaceLane, shift ops, Some BinOps and compare
ops
 - Add pshufhw, pshuflw in the assembler, disassembler
 - Fix incorrect modrm for pextrw, this bug disregards the register allocated
and always makes pextrw use rax. 
 - Fix pextrw disasm to take the 0 - 7 bits of the immediate instead of 0 - 3. 
 - Pextrw, pinsrw are in the assembler use 128 bit encodings, pextrw, pinsrw in
the disassembler use legacy encodings, fix inconsistencies causing weird code
gen when --print-code is used.
==========

[gdeepti, 2017-04-12 23:40:18]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 23:40:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 00:07:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 00:07:30]

Dry run: This issue passed the CQ dry run.

[bbudge, 2017-04-17 17:34:07]

https://codereview.chromium.org/2767983002/diff/200001/src/compiler/instructi...
File src/compiler/instruction-selector.cc (right):

https://codereview.chromium.org/2767983002/diff/200001/src/compiler/instructi...
src/compiler/instruction-selector.cc:2201: #endif  // V8_TARGET_ARCH_ARM
nit: !V8_TARGET_ARCH_ARM

https://codereview.chromium.org/2767983002/diff/200001/src/compiler/x64/code-...
File src/compiler/x64/code-generator-x64.cc (right):

https://codereview.chromium.org/2767983002/diff/200001/src/compiler/x64/code-...
src/compiler/x64/code-generator-x64.cc:2249: __ xorq(dst, dst);
Is this really needed? It seems like movsx (move word to quad word with sign
extension) should take care of this.

http://www.felixcloutier.com/x86/MOVSX:MOVSXD.html

https://codereview.chromium.org/2767983002/diff/200001/src/compiler/x64/code-...
src/compiler/x64/code-generator-x64.cc:2251: __ movsxwl(i.OutputRegister(),
i.OutputRegister());
nit: use dst here.

[gdeepti, 2017-04-17 17:46:22]

https://codereview.chromium.org/2767983002/diff/200001/src/compiler/instructi...
File src/compiler/instruction-selector.cc (right):

https://codereview.chromium.org/2767983002/diff/200001/src/compiler/instructi...
src/compiler/instruction-selector.cc:2201: #endif  // V8_TARGET_ARCH_ARM
On 2017/04/17 17:34:06, bbudge wrote:
> nit: !V8_TARGET_ARCH_ARM

Done.

https://codereview.chromium.org/2767983002/diff/200001/src/compiler/x64/code-...
File src/compiler/x64/code-generator-x64.cc (right):

https://codereview.chromium.org/2767983002/diff/200001/src/compiler/x64/code-...
src/compiler/x64/code-generator-x64.cc:2249: __ xorq(dst, dst);
On 2017/04/17 17:34:06, bbudge wrote:
> Is this really needed? It seems like movsx (move word to quad word with sign
> extension) should take care of this.
> 
> http://www.felixcloutier.com/x86/MOVSX:MOVSXD.html
> 

Not needed, left behind as a result of merge after assembler changes, here as
well as below. Fixed now.

https://codereview.chromium.org/2767983002/diff/200001/src/compiler/x64/code-...
src/compiler/x64/code-generator-x64.cc:2251: __ movsxwl(i.OutputRegister(),
i.OutputRegister());
On 2017/04/17 17:34:06, bbudge wrote:
> nit: use dst here.

Done.

[bbudge, 2017-04-17 17:53:28]

lgtm

[gdeepti, 2017-04-17 17:58:41]

gdeepti@chromium.org changed reviewers:
+ mtrofin@chromium.org

[gdeepti, 2017-04-17 17:58:42]

+mtrofin@ for OWNERS in src/compiler

[Mircea Trofin, 2017-04-17 18:16:19]

On 2017/04/17 17:58:42, gdeepti wrote:
> +mtrofin@ for OWNERS in src/compiler

rubber stamp lgtm

[gdeepti, 2017-04-17 18:19:27]

The CQ bit was checked by gdeepti@chromium.org

[commit-bot: I haz the power, 2017-04-17 18:19:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 18:47:46]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1492453167763050,
"parent_rev": "5b9b77655c3e5dc854e3afa388932299002a828e", "commit_rev":
"c8c03c150d2add866c09bf2aa866c6b4ed585b08"}

[commit-bot: I haz the power, 2017-04-17 18:47:53]

Description was changed from

==========
[wasm] Implement wasm x64 I16x8 Ops
 - Add I16x8 Splat, ExtractLane, ReplaceLane, shift ops, Some BinOps and compare
ops
 - Add pshufhw, pshuflw in the assembler, disassembler
 - Fix incorrect modrm for pextrw, this bug disregards the register allocated
and always makes pextrw use rax. 
 - Fix pextrw disasm to take the 0 - 7 bits of the immediate instead of 0 - 3. 
 - Pextrw, pinsrw are in the assembler use 128 bit encodings, pextrw, pinsrw in
the disassembler use legacy encodings, fix inconsistencies causing weird code
gen when --print-code is used.
==========

to

==========
[wasm] Implement wasm x64 I16x8 Ops
 - Add I16x8 Splat, ExtractLane, ReplaceLane, shift ops, Some BinOps and compare
ops
 - Add pshufhw, pshuflw in the assembler, disassembler
 - Fix incorrect modrm for pextrw, this bug disregards the register allocated
and always makes pextrw use rax. 
 - Fix pextrw disasm to take the 0 - 7 bits of the immediate instead of 0 - 3. 
 - Pextrw, pinsrw are in the assembler use 128 bit encodings, pextrw, pinsrw in
the disassembler use legacy encodings, fix inconsistencies causing weird code
gen when --print-code is used.

Review-Url: https://codereview.chromium.org/2767983002
Cr-Commit-Position: refs/heads/master@{#44664}
Committed:
https://chromium.googlesource.com/v8/v8/+/c8c03c150d2add866c09bf2aa866c6b4ed5...
==========

[commit-bot: I haz the power, 2017-04-17 18:47:54]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/v8/v8/+/c8c03c150d2add866c09bf2aa866c6b4ed5...