Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2767833002: (Reland) Use logdog butler subcommand to run tests. (Closed)

Created:
3 years, 9 months ago by BigBossZhiling
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke, jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

(Reland) Use logdog butler subcommand to run tests. Previously we ran tests, without setting butler environment variables. This will run into NotBootstrappedError when we try to upload test results through logdog. In this cl, we use logdog butler subcommand to run tests, which will set butler environment variables before hand. BUG=692287 Review-Url: https://codereview.chromium.org/2695963003 Cr-Commit-Position: refs/heads/master@{#456976} Committed: https://chromium.googlesource.com/chromium/src/+/de2df28c86b13227040aba5f9f5a1d1f869b81eb patch from issue 2695963003 at patchset 820001 (http://crrev.com/2695963003#ps820001) Review-Url: https://codereview.chromium.org/2767833002 Cr-Commit-Position: refs/heads/master@{#459281} Committed: https://chromium.googlesource.com/chromium/src/+/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6

Patch Set 1 #

Patch Set 2 : updated logdog #

Patch Set 3 : fixes revision logdog #

Patch Set 4 : increase timeout of tests #

Patch Set 5 : change timeout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -285 lines) Patch
M PRESUBMIT.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M build/android/BUILD.gn View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M build/android/pylib/android/logdog_logcat_monitor.py View 1 chunk +6 lines, -2 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M build/android/test_runner.py View 1 2 5 chunks +27 lines, -1 line 0 comments Download
M build/android/test_wrapper/logdog_wrapper.py View 1 chunk +56 lines, -59 lines 0 comments Download
A build/android/test_wrapper/logdog_wrapper.pydeps View 1 chunk +11 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +5 lines, -1 line 0 comments Download
M testing/buildbot/chromium.android.json View 1 2 3 4 111 chunks +111 lines, -111 lines 0 comments Download
M testing/buildbot/chromium.android.fyi.json View 1 31 chunks +31 lines, -31 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 73 chunks +73 lines, -73 lines 0 comments Download
M tools/mb/mb.py View 1 2 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
BigBossZhiling
3 years, 9 months ago (2017-03-22 01:24:23 UTC) #2
Dirk Pranke
lgtm if/when jbudorick is happy with it.
3 years, 9 months ago (2017-03-23 02:05:29 UTC) #4
jbudorick
lgtm but keep an eye on cycle time after this lands.
3 years, 9 months ago (2017-03-23 15:21:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767833002/80001
3 years, 9 months ago (2017-03-23 22:29:57 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 23:43:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/9b15df5f68a23a7c75af0e09ee52...

Powered by Google App Engine
This is Rietveld 408576698