Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2695963003: Use logdog butler subcommand to run tests. (Closed)

Created:
3 years, 10 months ago by BigBossZhiling
Modified:
3 years, 9 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use logdog butler subcommand to run tests. Previously we ran tests, without setting butler environment variables. This will run into NotBootstrappedError when we try to upload test results through logdog. In this cl, we use logdog butler subcommand to run tests, which will set butler environment variables before hand. BUG=692287 Review-Url: https://codereview.chromium.org/2695963003 Cr-Commit-Position: refs/heads/master@{#456976} Committed: https://chromium.googlesource.com/chromium/src/+/de2df28c86b13227040aba5f9f5a1d1f869b81eb

Patch Set 1 #

Total comments: 1

Patch Set 2 : add back signal logic #

Patch Set 3 : fixes #

Patch Set 4 : getting rid of logdog_wrapper.py #

Patch Set 5 : minor fixes #

Patch Set 6 : remove logdog_wrapper #

Total comments: 16

Patch Set 7 : fixes #

Patch Set 8 : fixes #

Total comments: 4

Patch Set 9 : using logdog_helper to uplaod #

Patch Set 10 : minor_fixes #

Total comments: 6

Patch Set 11 : fixes #

Total comments: 4

Patch Set 12 : recreate logdog wrapper #

Total comments: 15

Patch Set 13 : fixes #

Patch Set 14 : fixes #

Patch Set 15 : minor fixes again #

Total comments: 6

Patch Set 16 : fixes #

Total comments: 2

Patch Set 17 : address case comments #

Patch Set 18 : fixes #

Patch Set 19 : fixed it to not crash horribly on local #

Total comments: 5

Patch Set 20 : using context manager #

Total comments: 1

Patch Set 21 : update #

Patch Set 22 : add devil into sys path #

Patch Set 23 : add py_utils directory #

Patch Set 24 : add py_utils library #

Patch Set 25 : add logdog_wrapper in config #

Patch Set 26 : fixed the pydeps file #

Patch Set 27 : change internal_rules.gni #

Patch Set 28 : remove unnecessary deps #

Patch Set 29 : remove unnecessary deps #

Patch Set 30 : handle extra arguments #

Patch Set 31 : fix try bots #

Patch Set 32 : latest logdog version #

Patch Set 33 : environment variable quick fix #

Patch Set 34 : call os.environ #

Patch Set 35 : fix how we get swarming_bot_file #

Patch Set 36 : added service account json args #

Patch Set 37 : fix upload unified_logcats code #

Patch Set 38 : change the missed revision of logdog #

Total comments: 2

Patch Set 39 : minor fix of john's comment #

Patch Set 40 : after gclient sync #

Patch Set 41 : after rebase origin/master #

Patch Set 42 : adjust to new test_runner.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -241 lines) Patch
M PRESUBMIT.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 1 chunk +1 line, -0 lines 0 comments Download
M build/android/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +10 lines, -0 lines 0 comments Download
M build/android/test_runner.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 5 chunks +27 lines, -1 line 0 comments Download
M build/android/test_wrapper/logdog_wrapper.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +54 lines, -59 lines 0 comments Download
A build/android/test_wrapper/logdog_wrapper.pydeps View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +11 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 1 chunk +5 lines, -1 line 0 comments Download
M testing/buildbot/chromium.android.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 100 chunks +100 lines, -100 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 73 chunks +73 lines, -73 lines 0 comments Download
M tools/mb/mb.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 161 (100 generated)
BigBossZhiling
3 years, 10 months ago (2017-02-14 23:48:27 UTC) #3
jbudorick
https://codereview.chromium.org/2695963003/diff/1/build/android/test_wrapper/logdog_wrapper.py File build/android/test_wrapper/logdog_wrapper.py (right): https://codereview.chromium.org/2695963003/diff/1/build/android/test_wrapper/logdog_wrapper.py#newcode72 build/android/test_wrapper/logdog_wrapper.py:72: test_proc = subprocess.Popen(test_cmd) Why is this moving? We still ...
3 years, 10 months ago (2017-02-14 23:50:27 UTC) #4
jbudorick
On 2017/02/14 23:50:27, jbudorick wrote: > https://codereview.chromium.org/2695963003/diff/1/build/android/test_wrapper/logdog_wrapper.py > File build/android/test_wrapper/logdog_wrapper.py (right): > > https://codereview.chromium.org/2695963003/diff/1/build/android/test_wrapper/logdog_wrapper.py#newcode72 > ...
3 years, 10 months ago (2017-02-14 23:51:19 UTC) #5
BigBossZhiling
3 years, 10 months ago (2017-02-15 00:27:10 UTC) #7
jbudorick
(Sorry, should've done this w/ the original patchset.) Let's step back -- this wrapper exists ...
3 years, 10 months ago (2017-02-15 00:53:56 UTC) #8
BigBossZhiling
haven't copied the logic in this mb.py into another mb.py yet. If it looks good, ...
3 years, 10 months ago (2017-02-17 01:07:10 UTC) #9
chromium-reviews
Also if your initial check is ok, I will let Dan take a look too. ...
3 years, 10 months ago (2017-02-17 01:08:45 UTC) #10
mikecase (-- gone --)
I think this looks good, besides I would move logic to upload full logcat directly ...
3 years, 10 months ago (2017-02-17 01:40:58 UTC) #12
jbudorick
https://codereview.chromium.org/2695963003/diff/100001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/2695963003/diff/100001/tools/mb/mb.py#newcode1096 tools/mb/mb.py:1096: if not os.path.exists('./../../bin/logdog_butler'): This check doesn't work as intended, ...
3 years, 10 months ago (2017-02-17 01:46:21 UTC) #14
dnj
https://codereview.chromium.org/2695963003/diff/100001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/2695963003/diff/100001/tools/mb/mb.py#newcode1096 tools/mb/mb.py:1096: if not os.path.exists('./../../bin/logdog_butler'): Make this a constant (e.g., "butler_path") ...
3 years, 10 months ago (2017-02-17 16:54:52 UTC) #15
dnj
Also not terribly familiar with this code base. Does this function get run on the ...
3 years, 10 months ago (2017-02-17 17:30:22 UTC) #16
jbudorick
On 2017/02/17 17:30:22, dnj wrote: > Also not terribly familiar with this code base. Does ...
3 years, 10 months ago (2017-02-17 17:45:35 UTC) #17
BigBossZhiling
Should we use DIR_SOURCE_ROOT/bin/logdog_butler? https://codereview.chromium.org/2695963003/diff/100001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/2695963003/diff/100001/tools/mb/mb.py#newcode1096 tools/mb/mb.py:1096: if not os.path.exists('./../../bin/logdog_butler'): On 2017/02/17 ...
3 years, 10 months ago (2017-02-17 21:10:42 UTC) #18
jbudorick
On 2017/02/17 21:10:42, BigBossZhiling wrote: > Should we use DIR_SOURCE_ROOT/bin/logdog_butler? No, I don't think that's ...
3 years, 10 months ago (2017-02-17 21:11:38 UTC) #19
dnj
Suggestion: since you're running this on Swarming, LogDog is in CIPD, and Swarming can pre-install ...
3 years, 10 months ago (2017-02-18 07:59:25 UTC) #20
BigBossZhiling
https://codereview.chromium.org/2695963003/diff/140001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/2695963003/diff/140001/build/android/test_runner.py#newcode782 build/android/test_runner.py:782: swarming_task_id = os.environ['SWARMING_TASK_ID'] On 2017/02/18 07:59:25, dnj wrote: > ...
3 years, 10 months ago (2017-02-21 20:24:17 UTC) #21
jbudorick
On 2017/02/18 07:59:25, dnj wrote: > Suggestion: since you're running this on Swarming, LogDog is ...
3 years, 10 months ago (2017-02-21 20:48:09 UTC) #22
dnj
https://codereview.chromium.org/2695963003/diff/180001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/2695963003/diff/180001/tools/mb/mb.py#newcode18 tools/mb/mb.py:18: import logging It doesn't look like you're using this. ...
3 years, 10 months ago (2017-02-22 21:46:45 UTC) #23
dnj
On 2017/02/21 20:48:09, jbudorick wrote: > On 2017/02/18 07:59:25, dnj wrote: > > Suggestion: since ...
3 years, 10 months ago (2017-02-22 21:51:12 UTC) #24
BigBossZhiling
https://codereview.chromium.org/2695963003/diff/180001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/2695963003/diff/180001/tools/mb/mb.py#newcode18 tools/mb/mb.py:18: import logging On 2017/02/22 21:46:45, dnj wrote: > It ...
3 years, 10 months ago (2017-02-22 23:49:52 UTC) #25
dnj
https://codereview.chromium.org/2695963003/diff/200001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/2695963003/diff/200001/tools/mb/mb.py#newcode1097 tools/mb/mb.py:1097: streamserver_uri = 'unix:/tmp/butler.sock' This is a really generic name ...
3 years, 10 months ago (2017-02-22 23:57:02 UTC) #26
BigBossZhiling
https://codereview.chromium.org/2695963003/diff/200001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/2695963003/diff/200001/tools/mb/mb.py#newcode1097 tools/mb/mb.py:1097: streamserver_uri = 'unix:/tmp/butler.sock' On 2017/02/22 23:57:02, dnj wrote: > ...
3 years, 9 months ago (2017-02-27 19:43:17 UTC) #27
mikecase (-- gone --)
https://codereview.chromium.org/2695963003/diff/220001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/2695963003/diff/220001/build/android/test_runner.py#newcode783 build/android/test_runner.py:783: with open(args.upload_full_logcat) as src: should this be args.logcat_output_file? https://codereview.chromium.org/2695963003/diff/220001/build/android/test_wrapper/logdog_wrapper.py ...
3 years, 9 months ago (2017-02-27 20:25:49 UTC) #28
BigBossZhiling
https://codereview.chromium.org/2695963003/diff/220001/build/android/test_wrapper/logdog_wrapper.py File build/android/test_wrapper/logdog_wrapper.py (right): https://codereview.chromium.org/2695963003/diff/220001/build/android/test_wrapper/logdog_wrapper.py#newcode39 build/android/test_wrapper/logdog_wrapper.py:39: '--logcat-output-file', '${ISOLATED_OUTDIR}/logcats', On 2017/02/27 20:25:48, mikecase wrote: > We ...
3 years, 9 months ago (2017-02-27 21:24:42 UTC) #29
mikecase (-- gone --)
On 2017/02/27 at 21:24:42, hzl wrote: > https://codereview.chromium.org/2695963003/diff/220001/build/android/test_wrapper/logdog_wrapper.py > File build/android/test_wrapper/logdog_wrapper.py (right): > > https://codereview.chromium.org/2695963003/diff/220001/build/android/test_wrapper/logdog_wrapper.py#newcode39 ...
3 years, 9 months ago (2017-02-27 21:57:42 UTC) #30
BigBossZhiling
https://codereview.chromium.org/2695963003/diff/220001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/2695963003/diff/220001/build/android/test_runner.py#newcode783 build/android/test_runner.py:783: with open(args.upload_full_logcat) as src: On 2017/02/27 20:25:48, mikecase wrote: ...
3 years, 9 months ago (2017-02-27 22:47:52 UTC) #31
BigBossZhiling
3 years, 9 months ago (2017-02-27 22:47:52 UTC) #32
BigBossZhiling
On 2017/02/27 22:47:52, BigBossZhiling wrote: > https://codereview.chromium.org/2695963003/diff/220001/build/android/test_runner.py > File build/android/test_runner.py (right): > > https://codereview.chromium.org/2695963003/diff/220001/build/android/test_runner.py#newcode783 > ...
3 years, 9 months ago (2017-02-27 22:48:58 UTC) #33
jbudorick
https://codereview.chromium.org/2695963003/diff/220001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/2695963003/diff/220001/build/android/test_runner.py#newcode783 build/android/test_runner.py:783: with open(args.upload_full_logcat) as src: On 2017/02/27 20:25:48, mikecase wrote: ...
3 years, 9 months ago (2017-02-27 22:49:15 UTC) #34
jbudorick
https://codereview.chromium.org/2695963003/diff/220001/build/android/test_wrapper/logdog_wrapper.py File build/android/test_wrapper/logdog_wrapper.py (right): https://codereview.chromium.org/2695963003/diff/220001/build/android/test_wrapper/logdog_wrapper.py#newcode39 build/android/test_wrapper/logdog_wrapper.py:39: '--logcat-output-file', '${ISOLATED_OUTDIR}/logcats', On 2017/02/27 22:49:15, jbudorick wrote: > On ...
3 years, 9 months ago (2017-02-27 22:50:27 UTC) #35
BigBossZhiling
https://codereview.chromium.org/2695963003/diff/220001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/2695963003/diff/220001/build/android/test_runner.py#newcode783 build/android/test_runner.py:783: with open(args.upload_full_logcat) as src: On 2017/02/27 22:49:15, jbudorick wrote: ...
3 years, 9 months ago (2017-02-28 07:29:53 UTC) #36
dnj
looks reasonable https://codereview.chromium.org/2695963003/diff/280001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/2695963003/diff/280001/build/android/test_runner.py#newcode40 build/android/test_runner.py:40: from pylib.utils import logdog_helper Don't know what ...
3 years, 9 months ago (2017-02-28 18:28:38 UTC) #37
BigBossZhiling
https://codereview.chromium.org/2695963003/diff/280001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/2695963003/diff/280001/build/android/test_runner.py#newcode40 build/android/test_runner.py:40: from pylib.utils import logdog_helper On 2017/02/28 18:28:38, dnj wrote: ...
3 years, 9 months ago (2017-02-28 22:35:47 UTC) #38
mikecase (-- gone --)
https://codereview.chromium.org/2695963003/diff/300001/build/android/test_wrapper/logdog_wrapper.py File build/android/test_wrapper/logdog_wrapper.py (right): https://codereview.chromium.org/2695963003/diff/300001/build/android/test_wrapper/logdog_wrapper.py#newcode45 build/android/test_wrapper/logdog_wrapper.py:45: '--logcat-output-file', '${ISOLATED_OUTDIR}/logcats', Btw, martiniss@ said that swarming will automatically ...
3 years, 9 months ago (2017-03-01 18:15:32 UTC) #39
BigBossZhiling
addressed Case's comment https://codereview.chromium.org/2695963003/diff/300001/build/android/test_wrapper/logdog_wrapper.py File build/android/test_wrapper/logdog_wrapper.py (right): https://codereview.chromium.org/2695963003/diff/300001/build/android/test_wrapper/logdog_wrapper.py#newcode45 build/android/test_wrapper/logdog_wrapper.py:45: '--logcat-output-file', '${ISOLATED_OUTDIR}/logcats', On 2017/03/01 18:15:32, mikecase ...
3 years, 9 months ago (2017-03-02 23:17:14 UTC) #40
BigBossZhiling
https://codereview.chromium.org/2695963003/diff/360001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/2695963003/diff/360001/build/android/test_runner.py#newcode788 build/android/test_runner.py:788: dst = logdog_helper.open_text('unified_logcats') @mikecase's NotRaiseException doesn't raise any exception ...
3 years, 9 months ago (2017-03-04 00:59:14 UTC) #41
BigBossZhiling
https://codereview.chromium.org/2695963003/diff/360001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/2695963003/diff/360001/build/android/test_runner.py#newcode788 build/android/test_runner.py:788: dst = logdog_helper.open_text('unified_logcats') @mikecase's NotRaiseException doesn't raise any exception ...
3 years, 9 months ago (2017-03-04 00:59:15 UTC) #42
jbudorick
Close! https://codereview.chromium.org/2695963003/diff/360001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/2695963003/diff/360001/build/android/test_runner.py#newcode782 build/android/test_runner.py:782: if args.upload_logcats_file: We should handle this similarly to ...
3 years, 9 months ago (2017-03-04 01:22:33 UTC) #43
BigBossZhiling
https://codereview.chromium.org/2695963003/diff/360001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/2695963003/diff/360001/build/android/test_runner.py#newcode782 build/android/test_runner.py:782: if args.upload_logcats_file: On 2017/03/04 01:22:33, jbudorick wrote: > We ...
3 years, 9 months ago (2017-03-04 02:14:59 UTC) #44
jbudorick
lgtm w/ nit +dpranke for //tools/mb https://codereview.chromium.org/2695963003/diff/380001/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/2695963003/diff/380001/build/android/test_runner.py#newcode726 build/android/test_runner.py:726: with open(args.logcat_output_file) as ...
3 years, 9 months ago (2017-03-04 02:20:00 UTC) #46
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-07 00:29:26 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695963003/380001
3 years, 9 months ago (2017-03-08 00:35:54 UTC) #49
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/166409) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-08 00:39:59 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695963003/400001
3 years, 9 months ago (2017-03-08 00:46:55 UTC) #54
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/402399)
3 years, 9 months ago (2017-03-08 01:26:38 UTC) #56
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695963003/400001
3 years, 9 months ago (2017-03-08 20:11:05 UTC) #58
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/246739)
3 years, 9 months ago (2017-03-08 21:11:49 UTC) #60
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695963003/440001
3 years, 9 months ago (2017-03-09 05:14:27 UTC) #67
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/133642)
3 years, 9 months ago (2017-03-09 06:22:45 UTC) #69
jbudorick
lgtm w/ nit https://codereview.chromium.org/2695963003/diff/740001/build/config/android/internal_rules.gni File build/config/android/internal_rules.gni (right): https://codereview.chromium.org/2695963003/diff/740001/build/config/android/internal_rules.gni#newcode486 build/config/android/internal_rules.gni:486: data_deps += [ "//build/android:test_runner_py" ] nit: ...
3 years, 9 months ago (2017-03-14 20:41:40 UTC) #135
BigBossZhiling
https://codereview.chromium.org/2695963003/diff/740001/build/config/android/internal_rules.gni File build/config/android/internal_rules.gni (right): https://codereview.chromium.org/2695963003/diff/740001/build/config/android/internal_rules.gni#newcode486 build/config/android/internal_rules.gni:486: data_deps += [ "//build/android:test_runner_py" ] On 2017/03/14 20:41:40, jbudorick ...
3 years, 9 months ago (2017-03-14 20:48:25 UTC) #136
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695963003/760001
3 years, 9 months ago (2017-03-14 20:49:15 UTC) #139
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/250227)
3 years, 9 months ago (2017-03-14 21:57:29 UTC) #141
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695963003/760001
3 years, 9 months ago (2017-03-14 22:30:41 UTC) #143
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695963003/780001
3 years, 9 months ago (2017-03-14 22:39:32 UTC) #146
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/170393) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-14 22:43:29 UTC) #149
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695963003/800001
3 years, 9 months ago (2017-03-14 23:18:00 UTC) #152
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/250328)
3 years, 9 months ago (2017-03-15 00:09:14 UTC) #154
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695963003/820001
3 years, 9 months ago (2017-03-15 01:39:39 UTC) #157
commit-bot: I haz the power
Committed patchset #42 (id:820001) as https://chromium.googlesource.com/chromium/src/+/de2df28c86b13227040aba5f9f5a1d1f869b81eb
3 years, 9 months ago (2017-03-15 03:16:02 UTC) #160
BigBossZhiling
3 years, 9 months ago (2017-03-15 23:01:54 UTC) #161
Message was sent while issue was closed.
A revert of this CL (patchset #42 id:820001) has been created in
https://codereview.chromium.org/2749643008/ by hzl@google.com.

The reason for reverting is: Increases time by a great deal..

Powered by Google App Engine
This is Rietveld 408576698