Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2767783004:
Add proguard flags for JUnit4 tests (Closed)
|
Created:
3 years, 9 months ago by the real yoland Modified:
3 years, 9 months ago CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd proguard flags for JUnit4 tests
Skip proguard obfuscation or optimization for any JUnit4 or android
testing support library related classes.
BUG=640116
Review-Url: https://codereview.chromium.org/2767783004
Cr-Commit-Position: refs/heads/master@{#458644}
Committed: https://chromium.googlesource.com/chromium/src/+/435f259b846ab4d674d11b6600da57b4de7a1d58
Patch Set 1 #
Total comments: 2
Patch Set 2 : only Runner #
Dependent Patchsets: Messages
Total messages: 20 (8 generated)
yolandyan@chromium.org changed reviewers: + jbudorick@chromium.org, mikecase@chromium.org
Is this related to https://bugs.chromium.org/p/chromium/issues/detail?id=702152 ?
The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/21 at 23:58:15, jbudorick wrote: > Is this related to https://bugs.chromium.org/p/chromium/issues/detail?id=702152 ? Nope, this is related to this CL's failure: https://codereview.chromium.org/2760153002/#ps20001 I am working on that bug right now, it seems similar however, the reporter's build config uses incremental build, which should mean it's not obfuscated at all
https://codereview.chromium.org/2767783004/diff/1/testing/android/proguard_fo... File testing/android/proguard_for_test.flags (right): https://codereview.chromium.org/2767783004/diff/1/testing/android/proguard_fo... testing/android/proguard_for_test.flags:20: # Keep any class inherited from android testing support lib Why do we need these two additions?
https://codereview.chromium.org/2767783004/diff/1/testing/android/proguard_fo... File testing/android/proguard_for_test.flags (right): https://codereview.chromium.org/2767783004/diff/1/testing/android/proguard_fo... testing/android/proguard_for_test.flags:20: # Keep any class inherited from android testing support lib On 2017/03/22 at 00:17:20, jbudorick wrote: > Why do we need these two additions? AndroidJUnitRunner reflectively calls for class runner's constructor, without this one, runner would complain class runner class is not found Also, if the exception can match accurately to the line number, it makes debugging easier.
@jbudorick, Why do we run proguard on test apks? Did we ever end up bundling the Chrome.apk+ChromeTest.apk together?
lgtm
The CQ bit was checked by yolandyan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
The CQ bit was checked by yolandyan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490160328057240,
"parent_rev": "3e32ed5683dd6e1cf0178e07c6e58b0e8198a7c6", "commit_rev":
"435f259b846ab4d674d11b6600da57b4de7a1d58"}
Message was sent while issue was closed.
Description was changed from ========== Add proguard flags for JUnit4 tests Skip proguard obfuscation or optimization for any JUnit4 or android testing support library related classes. BUG=640116 ========== to ========== Add proguard flags for JUnit4 tests Skip proguard obfuscation or optimization for any JUnit4 or android testing support library related classes. BUG=640116 Review-Url: https://codereview.chromium.org/2767783004 Cr-Commit-Position: refs/heads/master@{#458644} Committed: https://chromium.googlesource.com/chromium/src/+/435f259b846ab4d674d11b6600da... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/435f259b846ab4d674d11b6600da... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
