Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2764213002:
Add findbugs filter to exclude UiThreadTestRule in java tests (Closed)
|
Created:
3 years, 9 months ago by the real yoland Modified:
3 years, 9 months ago CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd findbugs filter to exclude UiThreadTestRule in java tests
BUG=640116
Review-Url: https://codereview.chromium.org/2764213002
Cr-Commit-Position: refs/heads/master@{#458766}
Committed: https://chromium.googlesource.com/chromium/src/+/efd0b94f06c0d6566d9f7beeda45f5be337490c4
Patch Set 1 #
Total comments: 3
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 19 (7 generated)
yolandyan@chromium.org changed reviewers: + jbudorick@chromium.org, mikecase@chromium.org
The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Why does UiThreadTestRule trigger this warning? Will there be Rules that need similar exceptions in the future?
forgot to save this https://codereview.chromium.org/2764213002/diff/1/build/android/findbugs_filt... File build/android/findbugs_filter/findbugs_exclude.xml (right): https://codereview.chromium.org/2764213002/diff/1/build/android/findbugs_filt... build/android/findbugs_filter/findbugs_exclude.xml:34: <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD" /> Is UiThreadTestRule typically public or protected rather than private? Why?
https://codereview.chromium.org/2764213002/diff/1/build/android/findbugs_filt... File build/android/findbugs_filter/findbugs_exclude.xml (right): https://codereview.chromium.org/2764213002/diff/1/build/android/findbugs_filt... build/android/findbugs_filter/findbugs_exclude.xml:34: <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD" /> On 2017/03/22 15:43:48, jbudorick wrote: > Is UiThreadTestRule typically public or protected rather than private? Why? ah, nvm, found http://junit.org/junit4/javadoc/4.12/org/junit/Rule.html
On 2017/03/22 at 15:43:29, jbudorick wrote: > Why does UiThreadTestRule trigger this warning? Will there be Rules that need similar exceptions in the future? Because UiThreadTest something are not used by the test itself and just for @UiThreadTest annotation to work. It will be future once new runner lib comes out.
https://codereview.chromium.org/2764213002/diff/1/build/android/findbugs_filt... File build/android/findbugs_filter/findbugs_exclude.xml (right): https://codereview.chromium.org/2764213002/diff/1/build/android/findbugs_filt... build/android/findbugs_filter/findbugs_exclude.xml:34: <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD" /> On 2017/03/22 at 15:43:48, jbudorick wrote: > Is UiThreadTestRule typically public or protected rather than private? Why? It's always public because junit4 requires @Rule field to be public (in case security manager blocks class from accessing private field reflectively)
lgtm
The CQ bit was unchecked by yolandyan@chromium.org
The CQ bit was checked by yolandyan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490198117852070, "parent_rev":
"937020a5d3aad07a9096a1094b5ad727b4868a8a", "commit_rev":
"efd0b94f06c0d6566d9f7beeda45f5be337490c4"}
Message was sent while issue was closed.
Description was changed from ========== Add findbugs filter to exclude UiThreadTestRule in java tests BUG=640116 ========== to ========== Add findbugs filter to exclude UiThreadTestRule in java tests BUG=640116 Review-Url: https://codereview.chromium.org/2764213002 Cr-Commit-Position: refs/heads/master@{#458766} Committed: https://chromium.googlesource.com/chromium/src/+/efd0b94f06c0d6566d9f7beeda45... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/efd0b94f06c0d6566d9f7beeda45... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
