Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2767663002: Revert of Allow handles through for official builds too (partial revert) (Closed)

Created:
3 years, 9 months ago by scottmg
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow handles through for official builds too (partial revert) (patchset #3 id:40001 of https://codereview.chromium.org/2198603002/ ) Reason for revert: Potentially causing https://crbug.com/645319. Graph to watch to see if it helps: https://goto.google.com/nezdg BUG=645319 Original issue's description: > Allow handles through for official builds too (partial revert) > > This is a (very) partial revert of > https://codereview.chromium.org/1291553003 to fix the crash reported in > https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I > started trying to dig into making renderers log, but it's still a hairy > mess. > > R=wfh@chromium.org > BUG=625172, 358267, 579196 > TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash. > > Committed: https://crrev.com/5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9 > Cr-Commit-Position: refs/heads/master@{#409318} TBR=wfh@chromium.org,sky@chromium.org,thestig@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=625172, 358267, 579196 Review-Url: https://codereview.chromium.org/2767663002 Cr-Commit-Position: refs/heads/master@{#458513} Committed: https://chromium.googlesource.com/chromium/src/+/00c0c98ea999d1d8edde6d1a2c9d3e4ff1449117

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M base/process/launch_win.cc View 1 1 chunk +8 lines, -1 line 0 comments Download
M content/common/sandbox_win.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/content_browser_test_test.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
scottmg
Created Revert of Allow handles through for official builds too (partial revert)
3 years, 9 months ago (2017-03-21 18:20:14 UTC) #2
scottmg
Hey Chris, if I land this revert, will there be something that makes it clear ...
3 years, 9 months ago (2017-03-21 18:35:53 UTC) #12
chrisha
On 2017/03/21 18:35:53, scottmg wrote: > Hey Chris, if I land this revert, will there ...
3 years, 9 months ago (2017-03-21 19:04:16 UTC) #13
chrisha
(also, lgtm!)
3 years, 9 months ago (2017-03-21 19:10:25 UTC) #14
scottmg
On 2017/03/21 19:04:16, chrisha wrote: > On 2017/03/21 18:35:53, scottmg wrote: > > Hey Chris, ...
3 years, 9 months ago (2017-03-21 19:31:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767663002/80001
3 years, 9 months ago (2017-03-21 19:32:39 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 19:39:28 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/00c0c98ea999d1d8edde6d1a2c9d...

Powered by Google App Engine
This is Rietveld 408576698