content/common/sandbox_win.cc - Issue 2767663002: Revert of Allow handles through for official builds too (partial revert)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/sandbox_win.cc

Issue 2767663002: Revert of Allow handles through for official builds too (partial revert) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/sandbox_win.cc

diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc

index b8474b68268ece83f4109d2bb7371ab04547ee8c..c1ab69baa8fefd2271cb313e901a640ab4811520 100644

--- a/content/common/sandbox_win.cc

+++ b/content/common/sandbox_win.cc

@@ -815,10 +815,12 @@ sandbox::ResultCode StartSandboxedProcess(

}

+#if !defined(OFFICIAL_BUILD)

// If stdout/stderr point to a Windows console, these calls will

// have no effect. These calls can fail with SBOX_ERROR_BAD_PARAMS.

policy->SetStdoutHandle(GetStdHandle(STD_OUTPUT_HANDLE));

policy->SetStderrHandle(GetStdHandle(STD_ERROR_HANDLE));

+#endif

if (!delegate->PreSpawnTarget(policy.get()))

return sandbox::SBOX_ERROR_DELEGATE_PRE_SPAWN;

« no previous file with comments | « base/process/launch_win.cc ('k') | content/test/content_browser_test_test.cc » ('j') | no next file with comments »