Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 2767643003: [WebAPKs]: Run WebApkInstaller::OnInstallFinished() for Google Play updates (Closed)

Created:
3 years, 9 months ago by pkotwicz
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[WebAPKs]: Run WebApkInstaller::OnInstallFinished() for Google Play updates This CL: - fixes bug where WebApkInstaller#updateAsyncFromGooglePlay() was not calling nativeOnInstallFinished() - passes callback to GooglePlayWebApkInstallDelegate#installAsync() so that callback is called only after update completes Review-Url: https://codereview.chromium.org/2740003002 Cr-Commit-Position: refs/heads/master@{#456589} (cherry picked from commit 8c81f4b49feeac64da3f1ff1ff2dd58053420247) BUG=699879 Review-Url: https://codereview.chromium.org/2767643003 . Cr-Commit-Position: refs/branch-heads/3029@{#339} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/8d34d8a7b1dcccfa8ee2803000d0fab027f9eda0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pkotwicz
3 years, 9 months ago (2017-03-21 19:20:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d34d8a7b1dcccfa8ee2803000d0fab027f9eda0.

Powered by Google App Engine
This is Rietveld 408576698