[WebAPKs]: Run WebApkInstaller::OnInstallFinished() for Google Play updates

[WebAPKs]: Run WebApkInstaller::OnInstallFinished() for Google Play updates

This CL:
- fixes bug where WebApkInstaller#updateAsyncFromGooglePlay() was not
calling nativeOnInstallFinished()
- passes callback to GooglePlayWebApkInstallDelegate#installAsync() so that
callback is called only after update completes

Review-Url: https://codereview.chromium.org/2740003002
Cr-Commit-Position: refs/heads/master@{#456589}
Committed: https://chromium.googlesource.com/chromium/src/+/8c81f4b49feeac64da3f1ff1ff2dd58053420247

[pkotwicz, 2017-03-09 05:53:50]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2017-03-09 05:53:50]

Xi, can you please take a look?

I'll try to be more careful in the future when I am writing code

[Xi Han, 2017-03-10 13:48:32]

Sorry for the late reply, I thought I had sent out my comments.

https://codereview.chromium.org/2740003002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
(right):

https://codereview.chromium.org/2740003002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java:163:
notify(true);
I think you shouldn't call notify(true) here immediately. installAsync() will
call notify(), right?

[Xi Han, 2017-03-10 17:03:26]

https://codereview.chromium.org/2740003002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
(right):

https://codereview.chromium.org/2740003002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java:163:
notify(true);
On 2017/03/10 13:48:32, Xi Han wrote:
> I think you shouldn't call notify(true) here immediately. installAsync() will
> call notify(), right?

As discussed offline, we could keep it as it is now in this CL. Please file or
link to a bug to pass in the proper callback for Google Play update case:)

[pkotwicz, 2017-03-11 02:20:45]

Xi can you please take another look? I have changed the CL to pass a callback to
the GooglePlayWebApkInstallDelegate

[Xi Han, 2017-03-13 21:19:04]

LGTM!

[pkotwicz, 2017-03-13 21:28:52]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2017-03-13 21:28:52]

Dominick, can you please take a look?

[pkotwicz, 2017-03-13 21:29:48]

https://codereview.chromium.org/2740003002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
(right):

https://codereview.chromium.org/2740003002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java:125:
}
Looks like I need re-rebase this CL

[pkotwicz, 2017-03-13 21:56:21]

Rebased. Dominick, ready for your review

[dominickn, 2017-03-13 22:50:50]

lgtm, but can you attach a bug number please.

[dominickn, 2017-03-13 22:52:02]

On 2017/03/13 22:50:50, dominickn wrote:
> lgtm, but can you attach a bug number please.

Also the title doesn't seem to fit with the code. How about "Ensure Play WebAPK
updates pass a callback to the install delegate"

[pkotwicz, 2017-03-13 23:56:04]

Description was changed from

==========
[WebAPKs]: Run WebApkInstaller::UpdateAsync() for Google Play updates

This CL fixes bug where WebApkInstaller#updateAsyncFromGooglePlay() was not
calling nativeOnInstallFinished()
==========

to

==========
[WebAPKs]: Run WebApkInstaller::OnInstallFinished() for Google Play updates

This CL fixes bug where WebApkInstaller#updateAsyncFromGooglePlay() was not
calling nativeOnInstallFinished()
==========

[pkotwicz, 2017-03-13 23:58:14]

Description was changed from

==========
[WebAPKs]: Run WebApkInstaller::OnInstallFinished() for Google Play updates

This CL fixes bug where WebApkInstaller#updateAsyncFromGooglePlay() was not
calling nativeOnInstallFinished()
==========

to

==========
[WebAPKs]: Run WebApkInstaller::OnInstallFinished() for Google Play updates

This CL:
- fixes bug where WebApkInstaller#updateAsyncFromGooglePlay() was not
calling nativeOnInstallFinished()
- passes callback to GooglePlayWebApkInstallDelegate#installAsync() so that
callback is called only after update completes
==========

[pkotwicz, 2017-03-13 23:58:17]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-03-13 23:58:17]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org
Link to the patchset: https://codereview.chromium.org/2740003002/#ps60001
(title: "Merge branch 'start00' into start0")

[commit-bot: I haz the power, 2017-03-13 23:58:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 00:13:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 00:13:26]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[pkotwicz, 2017-03-14 01:43:36]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-03-14 01:44:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 02:44:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489455816347300,
"parent_rev": "b46b2120bd9c8b260513015717a9a09792f71714", "commit_rev":
"8c81f4b49feeac64da3f1ff1ff2dd58053420247"}

[commit-bot: I haz the power, 2017-03-14 02:45:35]

Description was changed from

==========
[WebAPKs]: Run WebApkInstaller::OnInstallFinished() for Google Play updates

This CL:
- fixes bug where WebApkInstaller#updateAsyncFromGooglePlay() was not
calling nativeOnInstallFinished()
- passes callback to GooglePlayWebApkInstallDelegate#installAsync() so that
callback is called only after update completes
==========

to

==========
[WebAPKs]: Run WebApkInstaller::OnInstallFinished() for Google Play updates

This CL:
- fixes bug where WebApkInstaller#updateAsyncFromGooglePlay() was not
calling nativeOnInstallFinished()
- passes callback to GooglePlayWebApkInstallDelegate#installAsync() so that
callback is called only after update completes

Review-Url: https://codereview.chromium.org/2740003002
Cr-Commit-Position: refs/heads/master@{#456589}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c81f4b49feeac64da3f1ff1ff2d...
==========

[commit-bot: I haz the power, 2017-03-14 02:45:39]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8c81f4b49feeac64da3f1ff1ff2d...