Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 2767633003: Revert of (Reland) Use logdog butler subcommand to run tests. (Closed)

Created:
3 years, 9 months ago by jbudorick
Modified:
3 years, 9 months ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of (Reland) Use logdog butler subcommand to run tests. (patchset #18 id:340001 of https://codereview.chromium.org/2753993002/ ) Reason for revert: https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/10403 Original issue's description: > (Reland) Use logdog butler subcommand to run tests. > > Previously we ran tests, without setting butler environment variables. > This will run into NotBootstrappedError when we try to upload test > results through logdog. > > In this cl, we use logdog butler subcommand to run tests, which will set > butler environment variables before hand. > > BUG=692287 > > Review-Url: https://codereview.chromium.org/2695963003 > Cr-Commit-Position: refs/heads/master@{#456976} > Committed: https://chromium.googlesource.com/chromium/src/+/de2df28c86b13227040aba5f9f5a1d1f869b81eb > > patch from issue 2695963003 at patchset 820001 (http://crrev.com/2695963003#ps820001) > > Review-Url: https://codereview.chromium.org/2753993002 > Cr-Commit-Position: refs/heads/master@{#458264} > Committed: https://chromium.googlesource.com/chromium/src/+/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5 TBR=dpranke@chromium.org,hzl@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=692287 Review-Url: https://codereview.chromium.org/2767633003 Cr-Commit-Position: refs/heads/master@{#458607} Committed: https://chromium.googlesource.com/chromium/src/+/86ea5a365e6c928bca676dd4621e6d9ef848e357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -296 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
M build/android/pylib/android/logdog_logcat_monitor.py View 1 chunk +2 lines, -6 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 2 chunks +1 line, -3 lines 0 comments Download
M build/android/test_runner.py View 5 chunks +1 line, -27 lines 0 comments Download
M build/android/test_wrapper/logdog_wrapper.py View 1 chunk +60 lines, -57 lines 0 comments Download
D build/android/test_wrapper/logdog_wrapper.pydeps View 1 chunk +0 lines, -11 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +1 line, -5 lines 0 comments Download
M testing/buildbot/chromium.android.json View 100 chunks +100 lines, -100 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 73 chunks +73 lines, -73 lines 0 comments Download
M tools/mb/mb.py View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jbudorick
Created Revert of (Reland) Use logdog butler subcommand to run tests.
3 years, 9 months ago (2017-03-22 00:12:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767633003/1
3 years, 9 months ago (2017-03-22 00:12:57 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 00:14:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/86ea5a365e6c928bca676dd4621e...

Powered by Google App Engine
This is Rietveld 408576698