Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2767553002: Fix priority test flakiness (Closed)

Created:
3 years, 9 months ago by Yoav Weiss
Modified:
3 years, 9 months ago
Reviewers:
horo
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix priority test flakiness A recently added priority test (added in https://codereview.chromium.org/2753053004 ) was preloading a resource but not using it, which flakily triggered unused preload warnings. This CL fixes that by using that preloaded resource. BUG=703446 Review-Url: https://codereview.chromium.org/2767553002 Cr-Commit-Position: refs/heads/master@{#458355} Committed: https://chromium.googlesource.com/chromium/src/+/6d8fbe34e1a68d526fda3b736ce006c42c30e21c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/resource-priority.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Yoav Weiss
3 years, 9 months ago (2017-03-21 07:42:40 UTC) #4
horo
LGTM. Thank you!
3 years, 9 months ago (2017-03-21 08:14:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767553002/1
3 years, 9 months ago (2017-03-21 09:05:13 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 09:11:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6d8fbe34e1a68d526fda3b736ce0...

Powered by Google App Engine
This is Rietveld 408576698