Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2753053004: Improve preload related priorities (Closed)

Created:
3 years, 9 months ago by Yoav Weiss
Modified:
3 years, 9 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, gavinp+loader_chromium.org, gavinp+prerender_chromium.org, Nate Chapin, kinuko+watch, kozyatinskiy+blink_chromium.org, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve preload related priorities While testing preload, I noticed a couple of related prioritization issues which make little sense: * Image discovery is used as a signal "bottom of page" scripts, even if the image was delivered using link preload. * Fonts are of a "very high" priority, which makes sense in their "natural" discovery order, but doesn't make sense for preloaded fonts, as we don't want them to content on bandwidth with more critical CSS and parser-blocking scripts. This CL changes the above to make sure that preloaded images are not used as a signal that scripts are "bottom page" ones, and to make sure that preloaded fonts are of "high" priority, rather than "very high". BUG= Review-Url: https://codereview.chromium.org/2753053004 Cr-Commit-Position: refs/heads/master@{#458037} Committed: https://chromium.googlesource.com/chromium/src/+/9d3f830376493925acf2e35b150b56ebcb7eeeaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network/resource-priority.html View 3 chunks +22 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/resource-priority-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 4 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Yoav Weiss
Hey Pat & Charlie, A couple of fixes for weird prioritization decisions I saw while ...
3 years, 9 months ago (2017-03-17 12:07:25 UTC) #4
Pat Meenan
lgtm
3 years, 9 months ago (2017-03-17 12:13:39 UTC) #5
Charlie Harrison
lgtm/2
3 years, 9 months ago (2017-03-18 01:00:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753053004/1
3 years, 9 months ago (2017-03-18 07:02:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/388837)
3 years, 9 months ago (2017-03-18 07:09:50 UTC) #12
Mike West
RS LGTM for //platform/loader.
3 years, 9 months ago (2017-03-20 08:45:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753053004/1
3 years, 9 months ago (2017-03-20 08:48:29 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 11:18:29 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d3f830376493925acf2e35b150b...

Powered by Google App Engine
This is Rietveld 408576698