Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2767493002: Try re-enabling WindowDotPrintShouldBringUpPrintPreview (Closed)

Created:
3 years, 9 months ago by rbpotter
Modified:
3 years, 9 months ago
Reviewers:
tapted
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Try re-enabling WindowDotPrintShouldBringUpPrintPreview Since bug 620194 is fixed, try re enabling the test to see if it is still flaky. Tested 100x on workstation and could not reproduce the CHECK it was hitting before. BUG=693305 Review-Url: https://codereview.chromium.org/2767493002 Cr-Commit-Position: refs/heads/master@{#458492} Committed: https://chromium.googlesource.com/chromium/src/+/0d57cf0fbb763f3e7b8cea4ffdea4213bd0c27c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/apps/app_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
rbpotter
3 years, 9 months ago (2017-03-21 01:57:48 UTC) #5
tapted
lgtm
3 years, 9 months ago (2017-03-21 02:20:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767493002/1
3 years, 9 months ago (2017-03-21 18:27:49 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 18:52:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0d57cf0fbb763f3e7b8cea4ffdea...

Powered by Google App Engine
This is Rietveld 408576698