Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chrome/browser/apps/app_browsertest.cc

Issue 2767493002: Try re-enabling WindowDotPrintShouldBringUpPrintPreview (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "apps/launcher.h" 9 #include "apps/launcher.h"
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 1113 matching lines...) Expand 10 before | Expand all | Expand 10 after
1124 1124
1125 EXPECT_EQ(1LU, GetAppWindowCount()); 1125 EXPECT_EQ(1LU, GetAppWindowCount());
1126 EXPECT_TRUE(GetFirstAppWindow() 1126 EXPECT_TRUE(GetFirstAppWindow()
1127 ->web_contents() 1127 ->web_contents()
1128 ->GetRenderWidgetHostView() 1128 ->GetRenderWidgetHostView()
1129 ->HasFocus()); 1129 ->HasFocus());
1130 } 1130 }
1131 1131
1132 #if BUILDFLAG(ENABLE_PRINT_PREVIEW) 1132 #if BUILDFLAG(ENABLE_PRINT_PREVIEW)
1133 1133
1134 // Disabled due to flakiness. See crbug.com/693305.
1135 // TODO(rbpotter): Investigate and re-enable this test.
1136 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, 1134 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
1137 DISABLED_WindowDotPrintShouldBringUpPrintPreview) { 1135 WindowDotPrintShouldBringUpPrintPreview) {
1138 ScopedPreviewTestingDelegate preview_delegate; 1136 ScopedPreviewTestingDelegate preview_delegate;
1139 ASSERT_TRUE(RunPlatformAppTest("platform_apps/print_api")) << message_; 1137 ASSERT_TRUE(RunPlatformAppTest("platform_apps/print_api")) << message_;
1140 preview_delegate.WaitUntilPreviewIsReady(); 1138 preview_delegate.WaitUntilPreviewIsReady();
1141 } 1139 }
1142 1140
1143 // This test verifies that http://crbug.com/297179 is fixed. 1141 // This test verifies that http://crbug.com/297179 is fixed.
1144 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, 1142 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
1145 DISABLED_ClosingWindowWhilePrintingShouldNotCrash) { 1143 DISABLED_ClosingWindowWhilePrintingShouldNotCrash) {
1146 ScopedPreviewTestingDelegate preview_delegate; 1144 ScopedPreviewTestingDelegate preview_delegate;
1147 ASSERT_TRUE(RunPlatformAppTest("platform_apps/print_api")) << message_; 1145 ASSERT_TRUE(RunPlatformAppTest("platform_apps/print_api")) << message_;
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
1363 } 1361 }
1364 1362
1365 // Sends chrome.test.sendMessage from chrome.app.window.create's callback. 1363 // Sends chrome.test.sendMessage from chrome.app.window.create's callback.
1366 // The app window also adds an <iframe> to the page during window.onload. 1364 // The app window also adds an <iframe> to the page during window.onload.
1367 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, AppWindowIframe) { 1365 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, AppWindowIframe) {
1368 LoadAndLaunchPlatformApp("app_window_send_message", 1366 LoadAndLaunchPlatformApp("app_window_send_message",
1369 "APP_WINDOW_CREATE_CALLBACK"); 1367 "APP_WINDOW_CREATE_CALLBACK");
1370 } 1368 }
1371 1369
1372 } // namespace extensions 1370 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698