Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp

Issue 2767343004: Return const references in the Blink SW API where possible (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp
diff --git a/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp b/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp
index 5d9e25b4848e77c9787af1d0036a112ca55ca53a..cbaad22c99ae62e1db40670f626dec4c2ed1b787 100644
--- a/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp
+++ b/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp
@@ -64,7 +64,7 @@ void WebServiceWorkerResponse::setStatusText(const WebString& statusText) {
m_private->statusText = statusText;
}
-WebString WebServiceWorkerResponse::statusText() const {
+const WebString& WebServiceWorkerResponse::statusText() const {
return m_private->statusText;
}
@@ -132,7 +132,7 @@ void WebServiceWorkerResponse::setStreamURL(const WebURL& url) {
m_private->streamURL = url;
}
-WebURL WebServiceWorkerResponse::streamURL() const {
+const WebURL& WebServiceWorkerResponse::streamURL() const {
return m_private->streamURL;
}
@@ -157,7 +157,7 @@ void WebServiceWorkerResponse::setCacheStorageCacheName(
m_private->cacheStorageCacheName = cacheStorageCacheName;
}
-WebString WebServiceWorkerResponse::cacheStorageCacheName() const {
+const WebString& WebServiceWorkerResponse::cacheStorageCacheName() const {
return m_private->cacheStorageCacheName;
}
@@ -166,7 +166,8 @@ void WebServiceWorkerResponse::setCorsExposedHeaderNames(
m_private->corsExposedHeaderNames = headerNames;
}
-WebVector<WebString> WebServiceWorkerResponse::corsExposedHeaderNames() const {
+const WebVector<WebString>& WebServiceWorkerResponse::corsExposedHeaderNames()
+ const {
return m_private->corsExposedHeaderNames;
}

Powered by Google App Engine
This is Rietveld 408576698