Issue 2767193003: [Reading List iOS] Test WebState on JavaScript return.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2767193003: [Reading List iOS] Test WebState on JavaScript return. (Closed)

Created:
3 years, 9 months ago by Olivier

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

[Reading List iOS] Test WebState on JavaScript return. ContinuePageDistillation can be called on return from JavaScript call. WebState can be deleted (specially if there was an error). So test before dereferencing it. BUG=703102 Review-Url: https://codereview.chromium.org/2761733003 Cr-Commit-Position: refs/heads/master@{#458061} (cherry picked from commit aca5aa3e2873c888092bf83668286b515e891bfb) Review-Url: https://codereview.chromium.org/2767193003 . Cr-Commit-Position: refs/branch-heads/3029@{#379} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/b47af0d4158c19302ac298009e80945b0fc4c3d1

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	ios/chrome/browser/reading_list/reading_list_distiller_page.mm	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Olivier

3 years, 9 months ago (2017-03-23 09:03:26 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b47af0d4158c19302ac298009e80945b0fc4c3d1.